You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@doris.apache.org by GitBox <gi...@apache.org> on 2023/01/05 08:43:39 UTC
[GitHub] [doris] yangzhg opened a new pull request, #15649: [chore](vulnerability) fix fe high risk vulnerability scanned by bug scanner
yangzhg opened a new pull request, #15649:
URL: https://github.com/apache/doris/pull/15649
## Problem summary
fix fe high risk vulnerability scanned by bug scanner
## Checklist(Required)
1. Does it affect the original behavior:
- [ ] Yes
- [x] No
- [ ] I don't know
2. Has unit tests been added:
- [ ] Yes
- [ ] No
- [x] No Need
3. Has document been added or modified:
- [ ] Yes
- [ ] No
- [x] No Need
4. Does it need to update dependencies:
- [ ] Yes
- [x] No
5. Are there any changes that cannot be rolled back:
- [ ] Yes (If Yes, please explain WHY)
- [x] No
## Further comments
If this is a relatively large or complex change, kick off the discussion at [dev@doris.apache.org](mailto:dev@doris.apache.org) by explaining why you chose the solution you did and what alternatives you considered, etc...
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [doris] github-actions[bot] commented on pull request #15649: [chore](vulnerability) fix fe high risk vulnerability scanned by bug scanner
Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on PR #15649:
URL: https://github.com/apache/doris/pull/15649#issuecomment-1375133683
PR approved by at least one committer and no changes requested.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [doris] github-actions[bot] commented on pull request #15649: [chore](vulnerability) fix fe high risk vulnerability scanned by bug scanner
Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on PR #15649:
URL: https://github.com/apache/doris/pull/15649#issuecomment-1373035723
PR approved by anyone and no changes requested.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [doris] github-actions[bot] commented on pull request #15649: [chore](vulnerability) fix fe high risk vulnerability scanned by bug scanner
Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on PR #15649:
URL: https://github.com/apache/doris/pull/15649#issuecomment-1376934170
PR approved by at least one committer and no changes requested.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [doris] yangzhg merged pull request #15649: [chore](vulnerability) fix fe high risk vulnerability scanned by bug scanner
Posted by GitBox <gi...@apache.org>.
yangzhg merged PR #15649:
URL: https://github.com/apache/doris/pull/15649
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [doris] hello-stephen commented on pull request #15649: [chore](vulnerability) fix fe high risk vulnerability scanned by bug scanner
Posted by GitBox <gi...@apache.org>.
hello-stephen commented on PR #15649:
URL: https://github.com/apache/doris/pull/15649#issuecomment-1372194537
TeamCity pipeline, clickbench performance test result:
the sum of best hot time: 36.83 seconds
load time: 655 seconds
storage size: 17123621264 Bytes
https://doris-community-test-1308700295.cos.ap-hongkong.myqcloud.com/tmp/20230105130726_clickbench_pr_74383.html
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [doris] morningman commented on a diff in pull request #15649: [chore](vulnerability) fix fe high risk vulnerability scanned by bug scanner
Posted by GitBox <gi...@apache.org>.
morningman commented on code in PR #15649:
URL: https://github.com/apache/doris/pull/15649#discussion_r1062607378
##########
fe/fe-core/src/main/java/org/apache/doris/common/util/DynamicPartitionUtil.java:
##########
@@ -740,8 +740,7 @@ public static String getHistoryPartitionRangeString(DynamicPartitionProperty dyn
date = simpleDateFormat.parse(time);
} catch (ParseException e) {
LOG.warn("Parse dynamic partition periods error. Error={}", e.getMessage());
- return getFormattedTimeWithoutMinuteSecond(
- ZonedDateTime.parse(timestamp.toString(), dateTimeFormatter), format);
+ throw new AnalysisException("Parse dynamic partition periods error. Error=" + e.getMessage());
Review Comment:
Why changing this logic?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [doris] github-actions[bot] commented on pull request #15649: [chore](vulnerability) fix fe high risk vulnerability scanned by bug scanner
Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on PR #15649:
URL: https://github.com/apache/doris/pull/15649#issuecomment-1373035687
PR approved by at least one committer and no changes requested.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [doris] yangzhg commented on a diff in pull request #15649: [chore](vulnerability) fix fe high risk vulnerability scanned by bug scanner
Posted by GitBox <gi...@apache.org>.
yangzhg commented on code in PR #15649:
URL: https://github.com/apache/doris/pull/15649#discussion_r1063021327
##########
fe/fe-core/src/main/java/org/apache/doris/common/util/DynamicPartitionUtil.java:
##########
@@ -740,8 +740,7 @@ public static String getHistoryPartitionRangeString(DynamicPartitionProperty dyn
date = simpleDateFormat.parse(time);
} catch (ParseException e) {
LOG.warn("Parse dynamic partition periods error. Error={}", e.getMessage());
- return getFormattedTimeWithoutMinuteSecond(
- ZonedDateTime.parse(timestamp.toString(), dateTimeFormatter), format);
+ throw new AnalysisException("Parse dynamic partition periods error. Error=" + e.getMessage());
Review Comment:
because of timestamp is null at this time
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org