You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@logging.apache.org by Gary Gregory <ga...@gmail.com> on 2018/10/22 19:38:01 UTC
Question about org.apache.logging.log4j.core.config.AbstractConfiguration.stop(long,
TimeUnit)
In org.apache.logging.log4j.core.config.AbstractConfiguration.stop(long,
TimeUnit), I see:
1) we stop the async appender
2) notify ReliabilityStrategies that appenders will be stopped
3) we stop the sync appender
I wonder if (2) was added in the wrong place and should come before (1)?
Gary
Re: Question about org.apache.logging.log4j.core.config.AbstractConfiguration.stop(long, TimeUnit)
Posted by Remko Popma <re...@gmail.com>.
Sorry, still haven’t had time to look at this.
(Shameless plug) Every java main() method deserves http://picocli.info
> On Nov 6, 2018, at 11:20, Gary Gregory <ga...@gmail.com> wrote:
>
>> On Tue, Oct 30, 2018 at 7:08 PM Gary Gregory <ga...@gmail.com> wrote:
>>
>>> On Mon, Oct 22, 2018 at 5:40 PM Remko Popma <re...@gmail.com> wrote:
>>>
>>> I’ll take a look.
>>>
>>
> Ping :-)
>
>
>>
>> Ping ;-)
>>
>> Gary
>>
>>>
>>>
>>>
>>>> On Oct 23, 2018, at 4:38, Gary Gregory <ga...@gmail.com> wrote:
>>>>
>>>> In org.apache.logging.log4j.core.config.AbstractConfiguration.stop(long,
>>>> TimeUnit), I see:
>>>>
>>>> 1) we stop the async appender
>>>> 2) notify ReliabilityStrategies that appenders will be stopped
>>>> 3) we stop the sync appender
>>>>
>>>> I wonder if (2) was added in the wrong place and should come before (1)?
>>>>
>>>> Gary
>>>
>>
Re: Question about org.apache.logging.log4j.core.config.AbstractConfiguration.stop(long,
TimeUnit)
Posted by Gary Gregory <ga...@gmail.com>.
On Tue, Oct 30, 2018 at 7:08 PM Gary Gregory <ga...@gmail.com> wrote:
> On Mon, Oct 22, 2018 at 5:40 PM Remko Popma <re...@gmail.com> wrote:
>
>> I’ll take a look.
>>
>
Ping :-)
>
> Ping ;-)
>
> Gary
>
>>
>>
>>
>> > On Oct 23, 2018, at 4:38, Gary Gregory <ga...@gmail.com> wrote:
>> >
>> > In org.apache.logging.log4j.core.config.AbstractConfiguration.stop(long,
>> > TimeUnit), I see:
>> >
>> > 1) we stop the async appender
>> > 2) notify ReliabilityStrategies that appenders will be stopped
>> > 3) we stop the sync appender
>> >
>> > I wonder if (2) was added in the wrong place and should come before (1)?
>> >
>> > Gary
>>
>
Re: Question about org.apache.logging.log4j.core.config.AbstractConfiguration.stop(long,
TimeUnit)
Posted by Gary Gregory <ga...@gmail.com>.
On Mon, Oct 22, 2018 at 5:40 PM Remko Popma <re...@gmail.com> wrote:
> I’ll take a look.
>
Ping ;-)
Gary
>
>
>
> > On Oct 23, 2018, at 4:38, Gary Gregory <ga...@gmail.com> wrote:
> >
> > In org.apache.logging.log4j.core.config.AbstractConfiguration.stop(long,
> > TimeUnit), I see:
> >
> > 1) we stop the async appender
> > 2) notify ReliabilityStrategies that appenders will be stopped
> > 3) we stop the sync appender
> >
> > I wonder if (2) was added in the wrong place and should come before (1)?
> >
> > Gary
>
Re: Question about org.apache.logging.log4j.core.config.AbstractConfiguration.stop(long, TimeUnit)
Posted by Remko Popma <re...@gmail.com>.
I’ll take a look.
> On Oct 23, 2018, at 4:38, Gary Gregory <ga...@gmail.com> wrote:
>
> In org.apache.logging.log4j.core.config.AbstractConfiguration.stop(long,
> TimeUnit), I see:
>
> 1) we stop the async appender
> 2) notify ReliabilityStrategies that appenders will be stopped
> 3) we stop the sync appender
>
> I wonder if (2) was added in the wrong place and should come before (1)?
>
> Gary