[jira] [Commented] (FLINK-8463) Remove unnecessary thread blocking in RestClient#submitRequest

["ASF GitHub Bot (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/FLINK-8463?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16332591#comment-16332591 ] 

ASF GitHub Bot commented on FLINK-8463:
---------------------------------------

GitHub user tillrohrmann opened a pull request:

    https://github.com/apache/flink/pull/5319

    [FLINK-8463] [rest] Remove blocking of IO executor in RestClient#submitRequest

    ## What is the purpose of the change
    
    Instead of waiting on the ChannelFuture we register a ChannelFutureListener which
    is notified when the channel has been established. This unblocks IO executor threads
    in the RestClient.
    
    
    ## Verifying this change
    
    This change is already covered by existing tests.
    
    ## Does this pull request potentially affect one of the following parts:
    
      - Dependencies (does it add or upgrade a dependency): (no)
      - The public API, i.e., is any changed class annotated with `@Public(Evolving)`: (no)
      - The serializers: (no)
      - The runtime per-record code paths (performance sensitive): (no)
      - Anything that affects deployment or recovery: JobManager (and its components), Checkpointing, Yarn/Mesos, ZooKeeper: (no)
      - The S3 file system connector: (no)
    
    ## Documentation
    
      - Does this pull request introduce a new feature? (no)
      - If yes, how is the feature documented? (not applicable)


You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/tillrohrmann/flink removeRestClientBlocking

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/flink/pull/5319.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #5319
    
----
commit bb0032ff74aa71b3e2f8be9bc201a00e28551280
Author: Till Rohrmann <tr...@...>
Date:   2018-01-19T17:27:22Z

    [FLINK-8463] [rest] Remove blocking of IO executor in RestClient#submitRequest
    
    Instead of waiting on the ChannelFuture we register a ChannelFutureListener which
    is notified when the channel has been established. This unblocks IO executor threads
    in the RestClient.

----


> Remove unnecessary thread blocking in RestClient#submitRequest
> --------------------------------------------------------------
>
>                 Key: FLINK-8463
>                 URL: https://issues.apache.org/jira/browse/FLINK-8463
>             Project: Flink
>          Issue Type: Bug
>          Components: REST
>    Affects Versions: 1.5.0
>            Reporter: Till Rohrmann
>            Assignee: Till Rohrmann
>            Priority: Major
>              Labels: flip-6
>             Fix For: 1.5.0
>
>
> The {{RestClient}} unnecessarily blocks an IO executor thread when trying to open a connection to a remote destination. This can be improved by registering a {{ChannelFuture}} listener which continues the execution once the connection has been established.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)