[jira] [Resolved] (THRIFT-3467) Go Maps for Thrift Sets Should Have Values of Type struct{}

["Jens Geyer (JIRA)" <ji...@apache.org>]

     [ https://issues.apache.org/jira/browse/THRIFT-3467?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Jens Geyer resolved THRIFT-3467.
--------------------------------
       Resolution: Fixed
    Fix Version/s: 0.11.0

Ok, thanks, committed.

> Go Maps for Thrift Sets Should Have Values of Type struct{} 
> ------------------------------------------------------------
>
>                 Key: THRIFT-3467
>                 URL: https://issues.apache.org/jira/browse/THRIFT-3467
>             Project: Thrift
>          Issue Type: Improvement
>          Components: Go - Compiler
>    Affects Versions: 0.9.3
>            Reporter: Tom Deering
>            Assignee: artem antonenko
>              Labels: golang
>             Fix For: 0.11.0
>
>
> Sets in Thrift are currently turned into maps with boolean values in Go. Example:
> Thrift
> {code}
> namespace go bug
> service FooService{
> 	void bar (1:set<string> foos)
> }
> {code}
> Go
> {code}
> func (p *FooServiceClient) Bar(foos map[string]bool) (err error) 
> {code}
> Boolean map values waste memory. Map values should be of the zero-byte struct{} type.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)