You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by GitBox <gi...@apache.org> on 2020/04/07 23:21:41 UTC

[GitHub] [spark] HeartSaVioR edited a comment on issue #28114: [SPARK-31330] Automatically label PRs based on the paths they touch

HeartSaVioR edited a comment on issue #28114: [SPARK-31330] Automatically label PRs based on the paths they touch
URL: https://github.com/apache/spark/pull/28114#issuecomment-610667025
 
 
   Thanks for the proposal and the work you've been done! 
   
   While I think this is huge one step forward, there's still some difference compared to the manual labelling, as manual labelling considers the module - like "Structured Streaming" which would be simply "SQL" for auto labelling and very hard to filter from SQL PRs.
   
   IMHO, if it's not hard to have our own auto labeler, following the marker for module representation (`[CORE]` or `[SQL]` or so) in PR title would work simpler if the auto labeler can update the label when the PR title has been changed. Reviewers would correct the marker if it's incorrect, not only for labelling but also for better commit history.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org