You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@pdfbox.apache.org by ti...@apache.org on 2022/04/22 12:34:25 UTC

svn commit: r1900155 - /pdfbox/trunk/pdfbox/src/main/java/org/apache/pdfbox/cos/COSArray.java

Author: tilman
Date: Fri Apr 22 12:34:25 2022
New Revision: 1900155

URL: http://svn.apache.org/viewvc?rev=1900155&view=rev
Log:
PDFBOX-4892: update state only if needed, as suggested by Valery Bokov

Modified:
    pdfbox/trunk/pdfbox/src/main/java/org/apache/pdfbox/cos/COSArray.java

Modified: pdfbox/trunk/pdfbox/src/main/java/org/apache/pdfbox/cos/COSArray.java
URL: http://svn.apache.org/viewvc/pdfbox/trunk/pdfbox/src/main/java/org/apache/pdfbox/cos/COSArray.java?rev=1900155&r1=1900154&r2=1900155&view=diff
==============================================================================
--- pdfbox/trunk/pdfbox/src/main/java/org/apache/pdfbox/cos/COSArray.java (original)
+++ pdfbox/trunk/pdfbox/src/main/java/org/apache/pdfbox/cos/COSArray.java Fri Apr 22 12:34:25 2022
@@ -407,8 +407,11 @@ public class COSArray extends COSBase im
      */
     public boolean remove( COSBase o )
     {
-        boolean removed = objects.remove( o );
-        getUpdateState().update();
+        boolean removed = objects.remove(o);
+        if (removed)
+        {
+            getUpdateState().update();
+        }
         return removed;
     }