[GitHub] [pulsar] sijie commented on a change in pull request #6742: [pulsar-client-tools] add tls truststore and hn-verification option to argument

[GitBox <gi...@apache.org>]

sijie commented on a change in pull request #6742:
URL: https://github.com/apache/pulsar/pull/6742#discussion_r411184024



##########
File path: pulsar-client-tools/src/main/java/org/apache/pulsar/client/cli/PulsarClientTool.java
##########
@@ -53,13 +53,18 @@
             "or \"{\"key1\":\"val1\",\"key2\":\"val2\"}.")
     String authParams = null;
 
+    @Parameter(names = { "--tls-trust-cert-path" }, description = "Allow TLS trust cert file path")
+    String tlsTrustCertsFilePath;
+
+    @Parameter(names = { "--tls-allow-insecure" }, description = "Allow TLS insecure connection")
+    Boolean tlsAllowInsecureConnection = null;

Review comment:
       This is a boxed value. 
   
   I think you need to change the value assignments in PulsarClientTool constructor.
   
   ```
           this.tlsAllowInsecureConnection = Boolean
                   .parseBoolean(properties.getProperty("tlsAllowInsecureConnection", "false"));
           this.tlsEnableHostnameVerification = Boolean
                   .parseBoolean(properties.getProperty("tlsEnableHostnameVerification", "false"));
           this.tlsTrustCertsFilePath = properties.getProperty("tlsTrustCertsFilePath");
   ```




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org