You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@dubbo.apache.org by GitBox <gi...@apache.org> on 2022/05/07 08:08:29 UTC
[GitHub] [dubbo] jefferson-chern opened a new pull request, #10011: consumer params should not be overwritten, fix 9922.
jefferson-chern opened a new pull request, #10011:
URL: https://github.com/apache/dubbo/pull/10011
## What is the purpose of the change
fix #9922
## Brief changelog
删除了消费者端从提供者端合并参数的操作。
## Verifying this change
<!-- Follow this checklist to help us incorporate your contribution quickly and easily: -->
## Checklist
- [x] Make sure there is a [GitHub_issue](https://github.com/apache/dubbo/issues) field for the change (usually before you start working on it). Trivial changes like typos do not require a GitHub issue. Your pull request should address just this issue, without pulling in other changes - one PR resolves one issue.
- [ ] Each commit in the pull request should have a meaningful subject line and body.
- [ ] Write a pull request description that is detailed enough to understand what the pull request does, how, and why.
- [ ] Check if is necessary to patch to Dubbo 3 if you are work on Dubbo 2.7
- [ ] Write necessary unit-test to verify your logic correction, more mock a little better when cross module dependency exist. If the new feature or significant change is committed, please remember to add sample in [dubbo samples](https://github.com/apache/dubbo-samples) project.
- [ ] Add some description to [dubbo-website](https://github.com/apache/dubbo-website) project if you are requesting to add a feature.
- [ ] GitHub Actions works fine on your own branch.
- [ ] If this contribution is large, please follow the [Software Donation Guide](https://github.com/apache/dubbo/wiki/Software-donation-guide).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For additional commands, e-mail: notifications-help@dubbo.apache.org
[GitHub] [dubbo] chickenlj commented on pull request #10011: consumer params should not be overwritten, fix 9922.
Posted by GitBox <gi...@apache.org>.
chickenlj commented on PR #10011:
URL: https://github.com/apache/dubbo/pull/10011#issuecomment-1120564223
> 当然还会引起 https://github.com/apache/dubbo/issues/8325 之类的问题,但是这些问题是不是应该解决。
这是两个相互矛盾的诉求,我们只能有优先级取舍。我认为我们应该遵循图中描述的,严格区分cluster层和isntance层的参数覆盖关系。
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For additional commands, e-mail: notifications-help@dubbo.apache.org
[GitHub] [dubbo] jefferson-chern commented on pull request #10011: consumer params should not be overwritten, fix 9922.
Posted by GitBox <gi...@apache.org>.
jefferson-chern commented on PR #10011:
URL: https://github.com/apache/dubbo/pull/10011#issuecomment-1120169513
我这两天翻阅了跟这行代码相关的issue #5971 #8325 #6426 #6926 和PR #9147 #6666 ,觉得 [这张图](https://github.com/apache/dubbo/issues/8325#issuecomment-953583050)表示的有些道理,消费者不应该感知提供者的这些配置,这些本来就是消费者自己提供的。所以删除这行代码比较合理,当然还会引起 #8325 之类的问题,但是这些问题是不是应该解决。
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For additional commands, e-mail: notifications-help@dubbo.apache.org
[GitHub] [dubbo] chickenlj commented on pull request #10011: consumer params should not be overwritten, fix 9922.
Posted by GitBox <gi...@apache.org>.
chickenlj commented on PR #10011:
URL: https://github.com/apache/dubbo/pull/10011#issuecomment-1120567649
非常感谢。但是当前 master 分之的话,我们更倾向于合并这个方案 https://github.com/apache/dubbo/pull/9933,因为它本身的兼容性问题更少。
但在 3.0 中我们会遵循你这里提到的思路,避免覆盖consumer端参数,请协助检查 3.0 相关逻辑。
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For additional commands, e-mail: notifications-help@dubbo.apache.org
[GitHub] [dubbo] chickenlj closed pull request #10011: consumer params should not be overwritten, fix 9922.
Posted by GitBox <gi...@apache.org>.
chickenlj closed pull request #10011: consumer params should not be overwritten, fix 9922.
URL: https://github.com/apache/dubbo/pull/10011
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For additional commands, e-mail: notifications-help@dubbo.apache.org