[GitHub] [mynewt-mcumgr] pabigot commented on a change in pull request #77: zephyr: Convert k_timer calls to new API

[GitBox <gi...@apache.org>]

pabigot commented on a change in pull request #77: zephyr: Convert k_timer calls to new API
URL: https://github.com/apache/mynewt-mcumgr/pull/77#discussion_r406715587
 
 

 ##########
 File path: cmd/os_mgmt/port/zephyr/src/zephyr_os_mgmt.c
 ##########
 @@ -91,6 +91,6 @@ zephyr_os_mgmt_reset_cb(struct k_timer *timer)
 int
 os_mgmt_impl_reset(unsigned int delay_ms)
 {
-    k_timer_start(&zephyr_os_mgmt_reset_timer, K_MSEC(delay_ms), 0);
+    k_timer_start(&zephyr_os_mgmt_reset_timer, K_MSEC(delay_ms), K_MSEC(0));
 
 Review comment:
   I believe the standard spelling when specifying no repeat interval is `K_NO_WAIT`.  The value may not be the same as as `K_MSEC(0)` as it was when integer values were used.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services