You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@datafusion.apache.org by gi...@apache.org on 2026/01/09 11:44:02 UTC
(datafusion-sqlparser-rs) 01/01: Key Value Options: add support for trailing semicolon (#2140)
This is an automated email from the ASF dual-hosted git repository.
github-bot pushed a commit to branch gh-readonly-queue/main/pr-2140-ab76a07bc292ba653e9d241e5c760ca2341a82a5
in repository https://gitbox.apache.org/repos/asf/datafusion-sqlparser-rs.git
commit d4fb5c3e6ee0099218dcef4a801d3fb4c0add7b3
Author: Yoav Cohen <59...@users.noreply.github.com>
AuthorDate: Fri Jan 9 12:43:38 2026 +0100
Key Value Options: add support for trailing semicolon (#2140)
---
src/parser/mod.rs | 9 +++++++--
tests/sqlparser_common.rs | 8 ++++++++
2 files changed, 15 insertions(+), 2 deletions(-)
diff --git a/src/parser/mod.rs b/src/parser/mod.rs
index 08ce9f1c..d0a774b5 100644
--- a/src/parser/mod.rs
+++ b/src/parser/mod.rs
@@ -18780,7 +18780,7 @@ impl<'a> Parser<'a> {
return self.expected(" another option or EOF", self.peek_token());
}
}
- Token::EOF => break,
+ Token::EOF | Token::SemiColon => break,
Token::Comma => {
delimiter = KeyValueOptionsDelimiter::Comma;
continue;
@@ -18792,7 +18792,12 @@ impl<'a> Parser<'a> {
self.prev_token();
break;
}
- _ => return self.expected("another option, EOF, Comma or ')'", self.peek_token()),
+ _ => {
+ return self.expected(
+ "another option, EOF, SemiColon, Comma or ')'",
+ self.peek_token(),
+ )
+ }
};
}
diff --git a/tests/sqlparser_common.rs b/tests/sqlparser_common.rs
index 4c3babd6..208a56e2 100644
--- a/tests/sqlparser_common.rs
+++ b/tests/sqlparser_common.rs
@@ -18052,3 +18052,11 @@ fn parse_overlap_as_bool_and() {
let dialects = all_dialects_where(|d| d.supports_double_ampersand_operator());
dialects.one_statement_parses_to("SELECT x && y", "SELECT x AND y");
}
+
+#[test]
+fn test_parse_key_value_options_trailing_semicolon() {
+ one_statement_parses_to(
+ "CREATE USER u1 option1='value1' option2='value2';",
+ "CREATE USER u1 option1='value1' option2='value2'",
+ );
+}
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@datafusion.apache.org
For additional commands, e-mail: commits-help@datafusion.apache.org