[GitHub] [airflow] fbertos commented on a change in pull request #20485: Add filter by state in DagRun REST API (List Dag Runs)

[GitBox <gi...@apache.org>]

fbertos commented on a change in pull request #20485:
URL: https://github.com/apache/airflow/pull/20485#discussion_r776860727



##########
File path: airflow/api_connexion/endpoints/dag_run_endpoint.py
##########
@@ -164,6 +165,9 @@ def get_dag_runs(
     else:
         query = query.filter(DagRun.dag_id == dag_id)
 
+    if state:
+        query = query.filter(DagRun.state.in_(state))

Review comment:
       Hi @kaxil, thanks for your recommendations. I will change the datatype to Optional[List[str]], however I am not sure it is a good idea to change to plural as it is defined in singular in the specification v1.yml, even being an array:
   
       FilterState:
         in: query
         **name: state**
         schema:
           **type: array**
           items:
             type: string
         required: false
         description:
           The value can be repeated to retrieve multiple matching values (OR condition).
   




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org