[GitHub] [skywalking] kezhenxu94 commented on a change in pull request #8179: [Feature] Support skip TLS host verify on ElasticSearch

[GitBox <gi...@apache.org>]

kezhenxu94 commented on a change in pull request #8179:
URL: https://github.com/apache/skywalking/pull/8179#discussion_r757822397



##########
File path: oap-server/server-storage-plugin/storage-elasticsearch-plugin/src/main/java/org/apache/skywalking/oap/server/storage/plugin/elasticsearch/StorageModuleElasticsearchConfig.java
##########
@@ -101,6 +101,12 @@
      * @since 7.0.0 This could be managed inside {@link #secretsManagementFile}
      */
     private String trustStorePass;
+
+    /**
+     * @since 8.8.2 Skip tls host verify on elasticsearch server

Review comment:
       ```suggestion
        * @since 8.9.0 Skip tls host verify on ElasticSearch server host
   ```

##########
File path: oap-server/server-library/library-client/src/main/java/org/apache/skywalking/oap/server/library/client/elasticsearch/ElasticSearchClient.java
##########
@@ -67,6 +67,9 @@
     @Setter
     private volatile String trustStorePass;
 
+    @Setter
+    private boolean skipHostVerify;

Review comment:
       ```suggestion
       private volatile boolean skipHostVerify;
   ```




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org