You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@kudu.apache.org by "Todd Lipcon (Code Review)" <ge...@cloudera.org> on 2017/01/12 23:12:01 UTC
[kudu-CR] docs: update quickstart to a new dataset
Hello Jean-Daniel Cryans,
I'd like you to do a code review. Please visit
http://gerrit.cloudera.org:8080/5701
to review the following change.
Change subject: docs: update quickstart to a new dataset
......................................................................
docs: update quickstart to a new dataset
The old dataset we were using seems to have changed formats
and no longer has unique identifiers, etc.
The new quickstart uses the SF MTA dataset, which is a bit nicer because
it's (a) bigger, (b) more time-series-like, and (c) has an associated
real-time feed so we could expand this tutorial more later.
Change-Id: If27de6e1b3d1a6178e036cbe68fd6812d5f74a94
---
M docs/quickstart.adoc
1 file changed, 80 insertions(+), 97 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/01/5701/1
--
To view, visit http://gerrit.cloudera.org:8080/5701
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: If27de6e1b3d1a6178e036cbe68fd6812d5f74a94
Gerrit-PatchSet: 1
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Todd Lipcon <to...@apache.org>
Gerrit-Reviewer: Jean-Daniel Cryans <jd...@apache.org>
[kudu-CR] docs: update quickstart to a new dataset
Posted by "Todd Lipcon (Code Review)" <ge...@cloudera.org>.
Todd Lipcon has posted comments on this change.
Change subject: docs: update quickstart to a new dataset
......................................................................
Patch Set 2:
(1 comment)
http://gerrit.cloudera.org:8080/#/c/5701/2/docs/quickstart.adoc
File docs/quickstart.adoc:
PS2, Line 201: 68MPH
> TBH I think it's in KMs.
shucks, that's a lot less fun than imagining some bus driver on a joy ride.
--
To view, visit http://gerrit.cloudera.org:8080/5701
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: If27de6e1b3d1a6178e036cbe68fd6812d5f74a94
Gerrit-PatchSet: 2
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Todd Lipcon <to...@apache.org>
Gerrit-Reviewer: Jean-Daniel Cryans <jd...@apache.org>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Todd Lipcon <to...@apache.org>
Gerrit-HasComments: Yes
[kudu-CR] docs: update quickstart to a new dataset
Posted by "Todd Lipcon (Code Review)" <ge...@cloudera.org>.
Todd Lipcon has submitted this change and it was merged.
Change subject: docs: update quickstart to a new dataset
......................................................................
docs: update quickstart to a new dataset
The old dataset we were using seems to have changed formats
and no longer has unique identifiers, etc.
The new quickstart uses the SF MTA dataset, which is a bit nicer because
it's (a) bigger, (b) more time-series-like, and (c) has an associated
real-time feed so we could expand this tutorial more later.
Change-Id: If27de6e1b3d1a6178e036cbe68fd6812d5f74a94
Reviewed-on: http://gerrit.cloudera.org:8080/5701
Reviewed-by: Jean-Daniel Cryans <jd...@apache.org>
Tested-by: Kudu Jenkins
---
M docs/quickstart.adoc
1 file changed, 80 insertions(+), 97 deletions(-)
Approvals:
Jean-Daniel Cryans: Looks good to me, approved
Kudu Jenkins: Verified
--
To view, visit http://gerrit.cloudera.org:8080/5701
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: If27de6e1b3d1a6178e036cbe68fd6812d5f74a94
Gerrit-PatchSet: 3
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Todd Lipcon <to...@apache.org>
Gerrit-Reviewer: Jean-Daniel Cryans <jd...@apache.org>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Todd Lipcon <to...@apache.org>
[kudu-CR] docs: update quickstart to a new dataset
Posted by "Todd Lipcon (Code Review)" <ge...@cloudera.org>.
Hello Jean-Daniel Cryans,
I'd like you to reexamine a change. Please visit
http://gerrit.cloudera.org:8080/5701
to look at the new patch set (#2).
Change subject: docs: update quickstart to a new dataset
......................................................................
docs: update quickstart to a new dataset
The old dataset we were using seems to have changed formats
and no longer has unique identifiers, etc.
The new quickstart uses the SF MTA dataset, which is a bit nicer because
it's (a) bigger, (b) more time-series-like, and (c) has an associated
real-time feed so we could expand this tutorial more later.
Change-Id: If27de6e1b3d1a6178e036cbe68fd6812d5f74a94
---
M docs/quickstart.adoc
1 file changed, 80 insertions(+), 97 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/01/5701/2
--
To view, visit http://gerrit.cloudera.org:8080/5701
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: If27de6e1b3d1a6178e036cbe68fd6812d5f74a94
Gerrit-PatchSet: 2
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Todd Lipcon <to...@apache.org>
Gerrit-Reviewer: Jean-Daniel Cryans <jd...@apache.org>
Gerrit-Reviewer: Kudu Jenkins
[kudu-CR] docs: update quickstart to a new dataset
Posted by "Jean-Daniel Cryans (Code Review)" <ge...@cloudera.org>.
Jean-Daniel Cryans has posted comments on this change.
Change subject: docs: update quickstart to a new dataset
......................................................................
Patch Set 2: Code-Review+2
(1 comment)
http://gerrit.cloudera.org:8080/#/c/5701/2/docs/quickstart.adoc
File docs/quickstart.adoc:
PS2, Line 201: 68MPH
TBH I think it's in KMs.
--
To view, visit http://gerrit.cloudera.org:8080/5701
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: If27de6e1b3d1a6178e036cbe68fd6812d5f74a94
Gerrit-PatchSet: 2
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Todd Lipcon <to...@apache.org>
Gerrit-Reviewer: Jean-Daniel Cryans <jd...@apache.org>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-HasComments: Yes