You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@qpid.apache.org by ro...@apache.org on 2010/07/16 17:19:03 UTC
svn commit: r964824 - in
/qpid/trunk/qpid/java/management/eclipse-plugin/src/main/java/org/apache/qpid/management/ui:
jmx/MBeanUtility.java views/AttributesTabControl.java
Author: robbie
Date: Fri Jul 16 15:19:01 2010
New Revision: 964824
URL: http://svn.apache.org/viewvc?rev=964824&view=rev
Log:
QPID-2731: enable the jmx management console to set boolean attribute values
Modified:
qpid/trunk/qpid/java/management/eclipse-plugin/src/main/java/org/apache/qpid/management/ui/jmx/MBeanUtility.java
qpid/trunk/qpid/java/management/eclipse-plugin/src/main/java/org/apache/qpid/management/ui/views/AttributesTabControl.java
Modified: qpid/trunk/qpid/java/management/eclipse-plugin/src/main/java/org/apache/qpid/management/ui/jmx/MBeanUtility.java
URL: http://svn.apache.org/viewvc/qpid/trunk/qpid/java/management/eclipse-plugin/src/main/java/org/apache/qpid/management/ui/jmx/MBeanUtility.java?rev=964824&r1=964823&r2=964824&view=diff
==============================================================================
--- qpid/trunk/qpid/java/management/eclipse-plugin/src/main/java/org/apache/qpid/management/ui/jmx/MBeanUtility.java (original)
+++ qpid/trunk/qpid/java/management/eclipse-plugin/src/main/java/org/apache/qpid/management/ui/jmx/MBeanUtility.java Fri Jul 16 15:19:01 2010
@@ -426,6 +426,15 @@ public class MBeanUtility
}
newValue = new Integer(Integer.parseInt(value));
}
+ else if (attribute.getDataType().equals(Boolean.class.getName()))
+ {
+ if (!value.equalsIgnoreCase("true") && !value.equalsIgnoreCase("false"))
+ {
+ throw new ManagementConsoleException("Entered value was not true or false");
+ }
+
+ newValue = new Boolean(Boolean.valueOf(value));
+ }
mbsc.setAttribute(jmxbean.getObjectName(), new Attribute(attribute.getName(), newValue));
// Update the value in the registry, to avoid refreshing from mbsc
Modified: qpid/trunk/qpid/java/management/eclipse-plugin/src/main/java/org/apache/qpid/management/ui/views/AttributesTabControl.java
URL: http://svn.apache.org/viewvc/qpid/trunk/qpid/java/management/eclipse-plugin/src/main/java/org/apache/qpid/management/ui/views/AttributesTabControl.java?rev=964824&r1=964823&r2=964824&view=diff
==============================================================================
--- qpid/trunk/qpid/java/management/eclipse-plugin/src/main/java/org/apache/qpid/management/ui/views/AttributesTabControl.java (original)
+++ qpid/trunk/qpid/java/management/eclipse-plugin/src/main/java/org/apache/qpid/management/ui/views/AttributesTabControl.java Fri Jul 16 15:19:01 2010
@@ -502,7 +502,10 @@ public class AttributesTabControl extend
if (attribute.isWritable())
{
value = _toolkit.createText(parent, "", SWT.BEGINNING | SWT.BORDER);
- value.addVerifyListener(new NumberVerifyListener());
+ if(attribute.isNumber())
+ {
+ value.addVerifyListener(new NumberVerifyListener());
+ }
// set data to access in the listener
parent.setData(attribute);
---------------------------------------------------------------------
Apache Qpid - AMQP Messaging Implementation
Project: http://qpid.apache.org
Use/Interact: mailto:commits-subscribe@qpid.apache.org