You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@dolphinscheduler.apache.org by GitBox <gi...@apache.org> on 2020/11/26 02:51:55 UTC
[GitHub] [incubator-dolphinscheduler] lenboo commented on a change in pull request #4097: [FIX-#4084][server]fix taskInstance state change error
lenboo commented on a change in pull request #4097:
URL: https://github.com/apache/incubator-dolphinscheduler/pull/4097#discussion_r530744310
##########
File path: dolphinscheduler-server/src/main/java/org/apache/dolphinscheduler/server/master/processor/queue/TaskResponseService.java
##########
@@ -126,51 +127,52 @@ public void run() {
/**
* persist taskResponseEvent
+ *
* @param taskResponseEvent taskResponseEvent
*/
- private void persist(TaskResponseEvent taskResponseEvent){
+ private void persist(TaskResponseEvent taskResponseEvent) {
Event event = taskResponseEvent.getEvent();
Channel channel = taskResponseEvent.getChannel();
- switch (event){
+ switch (event) {
case ACK:
try {
TaskInstance taskInstance = processService.findTaskInstanceById(taskResponseEvent.getTaskInstanceId());
- if (taskInstance != null){
- processService.changeTaskState(taskResponseEvent.getState(),
- taskResponseEvent.getStartTime(),
- taskResponseEvent.getWorkerAddress(),
- taskResponseEvent.getExecutePath(),
- taskResponseEvent.getLogPath(),
- taskResponseEvent.getTaskInstanceId());
+ if (taskInstance != null && ExecutionStatus.SUCCESS.getCode() != taskInstance.getState().getCode()) {
Review comment:
i think we should judge the task status finished: success/failed/stop...
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org