You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@eventmesh.apache.org by GitBox <gi...@apache.org> on 2021/11/07 15:20:00 UTC

[GitHub] [incubator-eventmesh] ruanwenjun opened a new pull request #581: [ISSUE #580] Add checkstyle gradle plugin

ruanwenjun opened a new pull request #581:
URL: https://github.com/apache/incubator-eventmesh/pull/581


   The check style will not be trigger in build, you need to manually execute `./gradlew check`.
   
   And this pr also change the plugin package code, when add a new plugin, need to add a gradle.properties file, and defined the plugin name.
   close #580 


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe@eventmesh.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@eventmesh.apache.org
For additional commands, e-mail: dev-help@eventmesh.apache.org

[GitHub] [incubator-eventmesh] xwm1992 merged pull request #581: [ISSUE #580] Add checkstyle gradle plugin

Posted by GitBox <gi...@apache.org>.
xwm1992 merged pull request #581:
URL: https://github.com/apache/incubator-eventmesh/pull/581


   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe@eventmesh.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@eventmesh.apache.org
For additional commands, e-mail: dev-help@eventmesh.apache.org

[GitHub] [incubator-eventmesh] ruanwenjun commented on pull request #581: [ISSUE #580] Add checkstyle gradle plugin

Posted by GitBox <gi...@apache.org>.
ruanwenjun commented on pull request #581:
URL: https://github.com/apache/incubator-eventmesh/pull/581#issuecomment-962760265


   Here are some error caused by check code style in build, I will take a look tonight.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe@eventmesh.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@eventmesh.apache.org
For additional commands, e-mail: dev-help@eventmesh.apache.org

[GitHub] [incubator-eventmesh] ruanwenjun commented on pull request #581: [ISSUE #580] Add checkstyle gradle plugin

Posted by GitBox <gi...@apache.org>.
ruanwenjun commented on pull request #581:
URL: https://github.com/apache/incubator-eventmesh/pull/581#issuecomment-962629599


   @qqeasonchen @xwm1992 This pr is ready for review, please take a look.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe@eventmesh.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@eventmesh.apache.org
For additional commands, e-mail: dev-help@eventmesh.apache.org

[GitHub] [incubator-eventmesh] ruanwenjun commented on pull request #581: [WIP][ISSUE #580] Add checkstyle gradle plugin

Posted by GitBox <gi...@apache.org>.
ruanwenjun commented on pull request #581:
URL: https://github.com/apache/incubator-eventmesh/pull/581#issuecomment-963025144


   @xwm1992 Now it's ready for review.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe@eventmesh.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@eventmesh.apache.org
For additional commands, e-mail: dev-help@eventmesh.apache.org

[GitHub] [incubator-eventmesh] qqeasonchen commented on pull request #581: [WIP][ISSUE #580] Add checkstyle gradle plugin

Posted by GitBox <gi...@apache.org>.
qqeasonchen commented on pull request #581:
URL: https://github.com/apache/incubator-eventmesh/pull/581#issuecomment-962763241


   LGTM


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe@eventmesh.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@eventmesh.apache.org
For additional commands, e-mail: dev-help@eventmesh.apache.org