You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@flink.apache.org by GitBox <gi...@apache.org> on 2022/04/07 15:38:36 UTC

[GitHub] [flink] zentol opened a new pull request, #19395: [FLINK-27118][yarn] TM ignores localhost BIND_HOST

zentol opened a new pull request, #19395:
URL: https://github.com/apache/flink/pull/19395

   Modifies the yarn taskexecutor runner to drop BIND_HOST configurations set to localhost, as done by the default distribution. 
   
   Localhost doesn't work out-of-the-box, and the TM still using it wasn't intentional.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [flink] flinkbot commented on pull request #19395: [FLINK-27118][yarn] TM ignores localhost BIND_HOST

Posted by GitBox <gi...@apache.org>.
flinkbot commented on PR #19395:
URL: https://github.com/apache/flink/pull/19395#issuecomment-1091901970

   <!--
   Meta data
   {
     "version" : 1,
     "metaDataEntries" : [ {
       "hash" : "265e973755e00eee30936febe002f0be174f0a22",
       "status" : "UNKNOWN",
       "url" : "TBD",
       "triggerID" : "265e973755e00eee30936febe002f0be174f0a22",
       "triggerType" : "PUSH"
     } ]
   }-->
   ## CI report:
   
   * 265e973755e00eee30936febe002f0be174f0a22 UNKNOWN
   
   <details>
   <summary>Bot commands</summary>
     The @flinkbot bot supports the following commands:
   
    - `@flinkbot run azure` re-run the last Azure build
   </details>


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [flink] gaoyunhaii closed pull request #19395: [FLINK-27118][yarn] TM ignores localhost BIND_HOST

Posted by GitBox <gi...@apache.org>.
gaoyunhaii closed pull request #19395: [FLINK-27118][yarn] TM ignores localhost BIND_HOST
URL: https://github.com/apache/flink/pull/19395


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [flink] gaoyunhaii commented on a diff in pull request #19395: [FLINK-27118][yarn] TM ignores localhost BIND_HOST

Posted by GitBox <gi...@apache.org>.
gaoyunhaii commented on code in PR #19395:
URL: https://github.com/apache/flink/pull/19395#discussion_r845984674


##########
flink-yarn/src/main/java/org/apache/flink/yarn/YarnTaskExecutorRunner.java:
##########
@@ -103,6 +103,11 @@ static void setupAndModifyConfiguration(
         BootstrapTools.updateTmpDirectoriesInConfiguration(configuration, localDirs);
 
         setupConfigurationFromVariables(configuration, currDir, variables);
+
+        configuration

Review Comment:
   This should be unnecessary if we have already removed the configuration in the client side~?



##########
flink-yarn/src/main/java/org/apache/flink/yarn/YarnTaskExecutorRunner.java:
##########
@@ -103,6 +103,11 @@ static void setupAndModifyConfiguration(
         BootstrapTools.updateTmpDirectoriesInConfiguration(configuration, localDirs);
 
         setupConfigurationFromVariables(configuration, currDir, variables);
+
+        configuration

Review Comment:
   This should be unnecessary if we have already removed the configuration in the client side~?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [flink] zentol commented on a diff in pull request #19395: [FLINK-27118][yarn] TM ignores localhost BIND_HOST

Posted by GitBox <gi...@apache.org>.
zentol commented on code in PR #19395:
URL: https://github.com/apache/flink/pull/19395#discussion_r845987774


##########
flink-yarn/src/main/java/org/apache/flink/yarn/YarnTaskExecutorRunner.java:
##########
@@ -103,6 +103,11 @@ static void setupAndModifyConfiguration(
         BootstrapTools.updateTmpDirectoriesInConfiguration(configuration, localDirs);
 
         setupConfigurationFromVariables(configuration, currDir, variables);
+
+        configuration

Review Comment:
   yes



##########
flink-yarn/src/main/java/org/apache/flink/yarn/YarnTaskExecutorRunner.java:
##########
@@ -103,6 +103,11 @@ static void setupAndModifyConfiguration(
         BootstrapTools.updateTmpDirectoriesInConfiguration(configuration, localDirs);
 
         setupConfigurationFromVariables(configuration, currDir, variables);
+
+        configuration

Review Comment:
   es



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [flink] zentol commented on pull request #19395: [FLINK-27118][yarn] TM ignores localhost BIND_HOST

Posted by GitBox <gi...@apache.org>.
zentol commented on PR #19395:
URL: https://github.com/apache/flink/pull/19395#issuecomment-1092539768

   > Perhaps we could still change it before printing the configuration
   
   This isn't possible since the printing is done when the config file is loaded, so any modifications must inherently occur afterwards.
   
   This also occurs on the JM side when it loads the configuration, with no real way to solve it.
   
   How about we just log an info message that we remove/change the bind-host setting?
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [flink] zoltar9264 commented on pull request #19395: [FLINK-27118][yarn] TM ignores localhost BIND_HOST

Posted by GitBox <gi...@apache.org>.
zoltar9264 commented on PR #19395:
URL: https://github.com/apache/flink/pull/19395#issuecomment-1092389273

   Hi @zentol , I meet this problem on 1.15.0-rc0 , and I just set _'taskmanager.bind-host'_ to 0.0.0.0 before seeing this pr. 
   Given the background I think this pr is handled appropriately, but I still recommend adding some clarification to flink-conf.yaml file to let users know that _'taskmanager.bind-host'_ doesn't take effect with yarn.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [flink] zentol commented on pull request #19395: [FLINK-27118][yarn] TM ignores localhost BIND_HOST

Posted by GitBox <gi...@apache.org>.
zentol commented on PR #19395:
URL: https://github.com/apache/flink/pull/19395#issuecomment-1092552100

   I've tried another approach where we remove the options on the client instead. This should work for both JM/TM processes and prevent any settings that aren't actually applied from being logged.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [flink] gaoyunhaii commented on pull request #19395: [FLINK-27118][yarn] TM ignores localhost BIND_HOST

Posted by GitBox <gi...@apache.org>.
gaoyunhaii commented on PR #19395:
URL: https://github.com/apache/flink/pull/19395#issuecomment-1092393242

   @flinkbot run azure


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [flink] gaoyunhaii commented on pull request #19395: [FLINK-27118][yarn] TM ignores localhost BIND_HOST

Posted by GitBox <gi...@apache.org>.
gaoyunhaii commented on PR #19395:
URL: https://github.com/apache/flink/pull/19395#issuecomment-1092424385

   Thanks @zentol for the PR! We have a manual test and it should be able to solve the connection problem, but there is one issue  that in the TaskManager's log, it would print all the configurations, but it happens before the value is changed, thus it would still show `localhost` and might cause some confusion. Perhaps we could still change it before printing the configuration or in the JM side? 


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org