[GitHub] [airflow] Taragolis commented on a diff in pull request #28241: Create Lambda create operator and sensor

[GitBox <gi...@apache.org>]

Taragolis commented on code in PR #28241:
URL: https://github.com/apache/airflow/pull/28241#discussion_r1044888713


##########
airflow/providers/amazon/aws/operators/lambda_function.py:
##########
@@ -20,35 +20,122 @@
 import json
 from typing import TYPE_CHECKING, Sequence
 
+from airflow.compat.functools import cached_property
 from airflow.models import BaseOperator
 from airflow.providers.amazon.aws.hooks.lambda_function import LambdaHook
 
 if TYPE_CHECKING:
     from airflow.utils.context import Context
 
 
-class AwsLambdaInvokeFunctionOperator(BaseOperator):
+class LambdaCreateFunctionOperator(BaseOperator):
     """
-    Invokes an AWS Lambda function.
-    You can invoke a function synchronously (and wait for the response),
-    or asynchronously.
-    To invoke a function asynchronously,
-    set `invocation_type` to `Event`. For more details,
-    review the boto3 Lambda invoke docs.
+    Creates an AWS Lambda function.
+
+    More information regarding parameters of this operator can be found here
+    https://boto3.amazonaws.com/v1/documentation/api/latest/reference/services/lambda.html#Lambda.Client.create_function
+
+    .. seealso::
+        For more information on how to use this operator, take a look at the guide:
+        :ref:`howto/operator:AwsLambdaCreateFunctionOperator`

Review Comment:
   The only one small thing that I've found. Reference in documentation has a different name



##########
docs/apache-airflow-providers-amazon/operators/lambda.rst:
##########
@@ -33,6 +33,20 @@ Prerequisite Tasks
 Operators
 ---------
 
+.. _howto/operator:AwsLambdaCreateFunctionOperator:
+
+Create an AWS Lambda function
+=============================
+
+To create an AWS lambda function you can use
+:class:`~airflow.providers.amazon.aws.operators.lambda_function.AwsLambdaCreateFunctionOperator`.

Review Comment:
   And vice versa



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org