You are viewing a plain text version of this content. The canonical link for it is here.

Posted to commits@nuttx.apache.org by GitBox <gi...@apache.org> on 2023/01/09 17:17:50 UTC

[GitHub] [nuttx] xiaoxiang781216 commented on a diff in pull request #8052: drivers/pipe:add PIPEIOC_POLLTHRES to set POLLIN/POLLOUT threshold

xiaoxiang781216 commented on code in PR #8052:
URL: https://github.com/apache/nuttx/pull/8052#discussion_r1064879886


##########
drivers/pipes/pipe_common.c:
##########
@@ -772,6 +796,20 @@ int pipecommon_ioctl(FAR struct file *filep, int cmd, unsigned long arg)
         }
         break;
 
+      case PIPEIOC_POLLTHRES:
+        {
+          pipe_ndx_t threshold = (pipe_ndx_t)arg;

Review Comment:
   should we support the different threshold for input/output? to avoid the reader and writer interference each other



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org