You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@flex.apache.org by Justin Mclean <ju...@classsoftware.com> on 2013/04/07 00:43:43 UTC
Re: git commit: FLEX-33477: Update ComboBox.as setSelectedIndex ASDOC comments to match that of the ListBase
Hi,
> + * @productversion Flex 4
May be best if we put ApacheFlex here that way we have a way to find methods that have been added in Apache Flex and mark then up in AsDocs (like the Air methods are).
Justin
Re: git commit: FLEX-33477: Update ComboBox.as setSelectedIndex ASDOC
comments to match that of the ListBase
Posted by Mark Kessler <ke...@gmail.com>.
Well then I'll go change those in here in a few.
On Sun, Apr 7, 2013 at 10:06 AM, Alex Harui <ah...@adobe.com> wrote:
>
>
>
> On 4/7/13 5:28 AM, "Mark Kessler" <ke...@gmail.com> wrote:
>
> > Ok so lets see if this is where we agree. The changes I just made on the
> > ComboBox and ListBase should keep the old values since they are existing
> > features I only changed the public scope. However new features that only
> > started existing with Apache Flex, such as the doubleClickMode; should
> have
> > the new version numbers.
> >
> > Does this sounds good?
> I think if you make a method public that was not previously protected, then
> it is now an official feature of the next release and the doc should
> reflect
> that. IOW, if you go back to 4.1, you can't just call setSelectedIndex.
> You would need to specify the mx_internal namespace. So I would use
> @productversion 4.10 or whatever on setSelectedIndex.
> >
> > -Mark
> >
> >
> > On Sun, Apr 7, 2013 at 12:13 AM, Alex Harui <ah...@adobe.com> wrote:
> >
> >>
> >>
> >>
> >> On 4/6/13 5:58 PM, "Justin Mclean" <ju...@classsoftware.com> wrote:
> >>
> >>> Hi,
> >>>
> >>>> So you would like something to the extent of [1]... for both the
> >> ComboBox
> >>>> and ListBase? I don't mind changing them, was just matching them to
> >> what
> >>>> they were supporting.
> >>>
> >>> There an open unresolved question if it means the version that it was
> >> added in
> >>> or the version it supports. I think the version it was added in make
> more
> >>> sense for the procduct tag, but the flash and AIR minimum version
> >> supported
> >>> (or perhaps tested) for the other two tags.
> >>
> >> I think it is the version of the pieces you need to make that API work.
> >>
> >> It is true that new APIs need the @productversion updated. These
> entries
> >> are used in the filter, so I would leave it as Flex instead of "Apache
> >> Flex"
> >> and update the version to 4.10 or whatever is correct. The version
> number
> >> can have "." in it. There are event 4.5.1 version numbers in the ASDoc.
> >>
> >> --
> >> Alex Harui
> >> Flex SDK Team
> >> Adobe Systems, Inc.
> >> http://blogs.adobe.com/aharui
> >>
> >>
>
> --
> Alex Harui
> Flex SDK Team
> Adobe Systems, Inc.
> http://blogs.adobe.com/aharui
>
>
Re: git commit: FLEX-33477: Update ComboBox.as setSelectedIndex
ASDOC comments to match that of the ListBase
Posted by Alex Harui <ah...@adobe.com>.
On 4/7/13 5:28 AM, "Mark Kessler" <ke...@gmail.com> wrote:
> Ok so lets see if this is where we agree. The changes I just made on the
> ComboBox and ListBase should keep the old values since they are existing
> features I only changed the public scope. However new features that only
> started existing with Apache Flex, such as the doubleClickMode; should have
> the new version numbers.
>
> Does this sounds good?
I think if you make a method public that was not previously protected, then
it is now an official feature of the next release and the doc should reflect
that. IOW, if you go back to 4.1, you can't just call setSelectedIndex.
You would need to specify the mx_internal namespace. So I would use
@productversion 4.10 or whatever on setSelectedIndex.
>
> -Mark
>
>
> On Sun, Apr 7, 2013 at 12:13 AM, Alex Harui <ah...@adobe.com> wrote:
>
>>
>>
>>
>> On 4/6/13 5:58 PM, "Justin Mclean" <ju...@classsoftware.com> wrote:
>>
>>> Hi,
>>>
>>>> So you would like something to the extent of [1]... for both the
>> ComboBox
>>>> and ListBase? I don't mind changing them, was just matching them to
>> what
>>>> they were supporting.
>>>
>>> There an open unresolved question if it means the version that it was
>> added in
>>> or the version it supports. I think the version it was added in make more
>>> sense for the procduct tag, but the flash and AIR minimum version
>> supported
>>> (or perhaps tested) for the other two tags.
>>
>> I think it is the version of the pieces you need to make that API work.
>>
>> It is true that new APIs need the @productversion updated. These entries
>> are used in the filter, so I would leave it as Flex instead of "Apache
>> Flex"
>> and update the version to 4.10 or whatever is correct. The version number
>> can have "." in it. There are event 4.5.1 version numbers in the ASDoc.
>>
>> --
>> Alex Harui
>> Flex SDK Team
>> Adobe Systems, Inc.
>> http://blogs.adobe.com/aharui
>>
>>
--
Alex Harui
Flex SDK Team
Adobe Systems, Inc.
http://blogs.adobe.com/aharui
Re: git commit: FLEX-33477: Update ComboBox.as setSelectedIndex ASDOC
comments to match that of the ListBase
Posted by Mark Kessler <ke...@gmail.com>.
Ok so lets see if this is where we agree. The changes I just made on the
ComboBox and ListBase should keep the old values since they are existing
features I only changed the public scope. However new features that only
started existing with Apache Flex, such as the doubleClickMode; should have
the new version numbers.
Does this sounds good?
-Mark
On Sun, Apr 7, 2013 at 12:13 AM, Alex Harui <ah...@adobe.com> wrote:
>
>
>
> On 4/6/13 5:58 PM, "Justin Mclean" <ju...@classsoftware.com> wrote:
>
> > Hi,
> >
> >> So you would like something to the extent of [1]... for both the
> ComboBox
> >> and ListBase? I don't mind changing them, was just matching them to
> what
> >> they were supporting.
> >
> > There an open unresolved question if it means the version that it was
> added in
> > or the version it supports. I think the version it was added in make more
> > sense for the procduct tag, but the flash and AIR minimum version
> supported
> > (or perhaps tested) for the other two tags.
>
> I think it is the version of the pieces you need to make that API work.
>
> It is true that new APIs need the @productversion updated. These entries
> are used in the filter, so I would leave it as Flex instead of "Apache
> Flex"
> and update the version to 4.10 or whatever is correct. The version number
> can have "." in it. There are event 4.5.1 version numbers in the ASDoc.
>
> --
> Alex Harui
> Flex SDK Team
> Adobe Systems, Inc.
> http://blogs.adobe.com/aharui
>
>
Re: git commit: FLEX-33477: Update ComboBox.as setSelectedIndex
ASDOC comments to match that of the ListBase
Posted by Alex Harui <ah...@adobe.com>.
On 4/6/13 9:25 PM, "Justin Mclean" <ju...@classsoftware.com> wrote:
> HI,
>
>> I would leave it as Flex instead of "Apache Flex" and update the version to
>> 4.10 or whatever is correct.
> Reason I suggested "Apache Flex" instead of "Flex" is so we can easily mark
> new apache stuff in the asdocs (like AIR only methods etc are marked in
> ASDocs) I did work on this ages ago and could revisit/check in. Would also be
> easy to search for in the code.
>
> Justin
All valid, but the filtering seems to work by product name and then by
version number. It seems like that would force folks to look in both Flex
and Apache Flex instead of just Flex. The docs probably should have a new
feature that filters out things greater than a version number.
--
Alex Harui
Flex SDK Team
Adobe Systems, Inc.
http://blogs.adobe.com/aharui
Re: git commit: FLEX-33477: Update ComboBox.as setSelectedIndex ASDOC comments to match that of the ListBase
Posted by Justin Mclean <ju...@classsoftware.com>.
HI,
> I would leave it as Flex instead of "Apache Flex" and update the version to 4.10 or whatever is correct.
Reason I suggested "Apache Flex" instead of "Flex" is so we can easily mark new apache stuff in the asdocs (like AIR only methods etc are marked in ASDocs) I did work on this ages ago and could revisit/check in. Would also be easy to search for in the code.
Justin
Re: git commit: FLEX-33477: Update ComboBox.as setSelectedIndex
ASDOC comments to match that of the ListBase
Posted by Alex Harui <ah...@adobe.com>.
On 4/6/13 5:58 PM, "Justin Mclean" <ju...@classsoftware.com> wrote:
> Hi,
>
>> So you would like something to the extent of [1]... for both the ComboBox
>> and ListBase? I don't mind changing them, was just matching them to what
>> they were supporting.
>
> There an open unresolved question if it means the version that it was added in
> or the version it supports. I think the version it was added in make more
> sense for the procduct tag, but the flash and AIR minimum version supported
> (or perhaps tested) for the other two tags.
I think it is the version of the pieces you need to make that API work.
It is true that new APIs need the @productversion updated. These entries
are used in the filter, so I would leave it as Flex instead of "Apache Flex"
and update the version to 4.10 or whatever is correct. The version number
can have "." in it. There are event 4.5.1 version numbers in the ASDoc.
--
Alex Harui
Flex SDK Team
Adobe Systems, Inc.
http://blogs.adobe.com/aharui
Re: git commit: FLEX-33477: Update ComboBox.as setSelectedIndex ASDOC comments to match that of the ListBase
Posted by Justin Mclean <ju...@classsoftware.com>.
Hi,
> So you would like something to the extent of [1]... for both the ComboBox
> and ListBase? I don't mind changing them, was just matching them to what
> they were supporting.
There an open unresolved question if it means the version that it was added in or the version it supports. I think the version it was added in make more sense for the procduct tag, but the flash and AIR minimum version supported (or perhaps tested) for the other two tags.
Justin
Re: git commit: FLEX-33477: Update ComboBox.as setSelectedIndex ASDOC
comments to match that of the ListBase
Posted by Mark Kessler <ke...@gmail.com>.
So you would like something to the extent of [1]... for both the ComboBox
and ListBase? I don't mind changing them, was just matching them to what
they were supporting.
[1] * @productversion ApacheFlex 4.9
On Sat, Apr 6, 2013 at 6:43 PM, Justin Mclean <ju...@classsoftware.com>wrote:
> Hi,
>
> > + * @productversion Flex 4
>
> May be best if we put ApacheFlex here that way we have a way to find
> methods that have been added in Apache Flex and mark then up in AsDocs
> (like the Air methods are).
>
> Justin
Re: git commit: FLEX-33477: Update ComboBox.as setSelectedIndex ASDOC
comments to match that of the ListBase
Posted by Mark Kessler <ke...@gmail.com>.
BTW should we go back and change that for the previous changes we done as
well? Such as that doubleClickMode. Do we update the flash version and
air version to the current one we are on as well?
On Sat, Apr 6, 2013 at 6:43 PM, Justin Mclean <ju...@classsoftware.com>wrote:
> Hi,
>
> > + * @productversion Flex 4
>
> May be best if we put ApacheFlex here that way we have a way to find
> methods that have been added in Apache Flex and mark then up in AsDocs
> (like the Air methods are).
>
> Justin