You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@yunikorn.apache.org by GitBox <gi...@apache.org> on 2022/12/05 06:26:37 UTC
[GitHub] [yunikorn-core] wilfred-s opened a new pull request, #466: [YUNIKORN-1445] partition cleanup: refactor code
wilfred-s opened a new pull request, #466:
URL: https://github.com/apache/yunikorn-core/pull/466
### What is this PR for?
The cleanup code needs a "cleanup"
Refactoring of cleanupExpiredApps to rely on just application ID lists. Make GetAppsByState, GetRejectedAppsByState & GetCompletedAppsByState internal to the partition and change the return value
Remove GetAppsInTerminatedState and GetTotalCompletedApplicationCount as they are unused or only for test and not needed.
Cleanup tests to use assert.Equal instead of asser.Assert
### What type of PR is it?
* [X] - Refactoring
### What is the Jira issue?
* https://issues.apache.org/jira/browse/YUNIKORN-1445
### How should this be tested?
Covered by existing unit test.
Code coverage should increase slightly as checks are run via methods instead of direct value access
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@yunikorn.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [yunikorn-core] wilfred-s closed pull request #466: [YUNIKORN-1445] partition cleanup: refactor code
Posted by GitBox <gi...@apache.org>.
wilfred-s closed pull request #466: [YUNIKORN-1445] partition cleanup: refactor code
URL: https://github.com/apache/yunikorn-core/pull/466
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@yunikorn.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [yunikorn-core] codecov[bot] commented on pull request #466: [YUNIKORN-1445] partition cleanup: refactor code
Posted by GitBox <gi...@apache.org>.
codecov[bot] commented on PR #466:
URL: https://github.com/apache/yunikorn-core/pull/466#issuecomment-1336813074
# [Codecov](https://codecov.io/gh/apache/yunikorn-core/pull/466?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
> Merging [#466](https://codecov.io/gh/apache/yunikorn-core/pull/466?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (73fe312) into [master](https://codecov.io/gh/apache/yunikorn-core/commit/22cd8ca1da017cede65c470f2f30708fa7153b9c?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (22cd8ca) will **increase** coverage by `0.13%`.
> The diff coverage is `100.00%`.
```diff
@@ Coverage Diff @@
## master #466 +/- ##
==========================================
+ Coverage 72.60% 72.74% +0.13%
==========================================
Files 67 67
Lines 10079 10057 -22
==========================================
- Hits 7318 7316 -2
+ Misses 2514 2495 -19
+ Partials 247 246 -1
```
| [Impacted Files](https://codecov.io/gh/apache/yunikorn-core/pull/466?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | |
|---|---|---|
| [pkg/scheduler/partition.go](https://codecov.io/gh/apache/yunikorn-core/pull/466/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cGtnL3NjaGVkdWxlci9wYXJ0aXRpb24uZ28=) | `77.10% <100.00%> (+1.38%)` | :arrow_up: |
:mega: We’re building smart automated test selection to slash your CI/CD build times. [Learn more](https://about.codecov.io/iterative-testing/?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@yunikorn.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org