You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@tapestry.apache.org by jk...@apache.org on 2007/10/22 23:04:56 UTC
svn commit: r587251 -
/tapestry/tapestry4/trunk/tapestry-framework/src/js/tapestry/core.js
Author: jkuhnert
Date: Mon Oct 22 14:04:55 2007
New Revision: 587251
URL: http://svn.apache.org/viewvc?rev=587251&view=rev
Log:
Fixes TAPESTRY-1854. Added explicit check for node attribute name of "value" and set the value directly.
Modified:
tapestry/tapestry4/trunk/tapestry-framework/src/js/tapestry/core.js
Modified: tapestry/tapestry4/trunk/tapestry-framework/src/js/tapestry/core.js
URL: http://svn.apache.org/viewvc/tapestry/tapestry4/trunk/tapestry-framework/src/js/tapestry/core.js?rev=587251&r1=587250&r2=587251&view=diff
==============================================================================
--- tapestry/tapestry4/trunk/tapestry-framework/src/js/tapestry/core.js (original)
+++ tapestry/tapestry4/trunk/tapestry-framework/src/js/tapestry/core.js Mon Oct 22 14:04:55 2007
@@ -267,10 +267,8 @@
if (tapestry.isIE && node.outerHTML && node.nodeName == "SELECT") {
node.outerHTML = node.outerHTML.replace(/(<SELECT[^<]*>).*(<\/SELECT>)/, '$1' + content + '$2');
node=dojo.byId(id);
- } else {
- if (content && content.length > 0) {
- node.innerHTML=content;
- }
+ } else if (content && content.length > 0){
+ node.innerHTML=content;
}
// copy attributes
@@ -295,7 +293,9 @@
dojo.html.setStyleText(node, nv);
} else if (nn == "class") {
dojo.html.setClass(node, nv);
- } else {
+ } else if (nn == "value") {
+ node.value = nv;
+ } else {
node.setAttribute(nn, nv);
}
}
@@ -595,35 +595,38 @@
return s;
},
- /**
- * Adds togglers and js effects to the exception page.
- */
- enhanceExceptionPage:function(){
- dojo.require("dojo.html.style");
- // attach toggles + hide content
- var elms=dojo.html.getElementsByClass('toggle');
- if(elms && elms.length > 0){
- for(var i=0;i<elms.length;i++){
- dojo.event.connect(elms[i], "onclick", function(e) {
- var thisLink = e.target;
- dojo.html.toggleShowing(dojo.byId(thisLink.id + 'Data'));
- if(dojo.html.hasClass(thisLink, "toggleSelected"))
- dojo.html.removeClass(thisLink, "toggleSelected")
- else
- dojo.html.addClass(thisLink, "toggleSelected");
- if (e.preventDefault)
- dojo.event.browser.stopEvent(e);
- return false;
- });
- dojo.html.toggleShowing(elms[i].id+'Data');
- }
+ /**
+ * Adds togglers and js effects to the exception page.
+ */
+ enhanceExceptionPage:function(){
+ // attach toggles + hide content
+
+ var elms=dojo.html.getElementsByClass('toggle');
+
+ if(elms && elms.length > 0){
+ for(var i=0;i<elms.length;i++){
+
+ dojo.event.connect(elms[i], "onclick", function(e) {
+ var thisLink = e.target;
+ dojo.html.toggleShowing(dojo.byId(thisLink.id + 'Data'));
+ if(dojo.html.hasClass(thisLink, "toggleSelected"))
+ dojo.html.removeClass(thisLink, "toggleSelected")
+ else
+ dojo.html.addClass(thisLink, "toggleSelected");
+ if (e.preventDefault)
+ dojo.event.browser.stopEvent(e);
+ return false;
+ });
+ dojo.html.toggleShowing(elms[i].id+'Data');
}
- // but show last exception's content
- elms=dojo.html.getElementsByClass('exception-link');
- if(elms && elms.length > 0){
- elms[elms.length-1].onclick({target:elms[elms.length-1]});
- }
- },
+ }
+
+ // but show last exception's content
+ elms=dojo.html.getElementsByClass('exception-link');
+ if(elms && elms.length > 0){
+ elms[elms.length-1].onclick({target:elms[elms.length-1]});
+ }
+ },
_getContentAsStringIE:function(node){
var s=" "; //blank works around an IE-bug