You are viewing a plain text version of this content. The canonical link for it is here.

Posted to issues@ozone.apache.org by GitBox <gi...@apache.org> on 2020/04/17 08:40:47 UTC

[GitHub] [hadoop-ozone] elek commented on issue #809: HDDS-2576. Handle InterruptedException in OzoneManagerDoubleBuffer

elek commented on issue #809: HDDS-2576. Handle InterruptedException in OzoneManagerDoubleBuffer
URL: https://github.com/apache/hadoop-ozone/pull/809#issuecomment-615121993
 
 
   Thanks to post this patch @danidelvalle 
   
   I am trying to understand this part of the code, and it seems to be false positive. As the daemon thread is interrupted right before, I think it's safe to ignore the `InterruptedException`.
   
   Especially as with the proposed approach the metrics (after these lines) won't be stopped. 
   
   I am not sure what is the good approach here, I think it's more safe to keep it as is, but I can be convinced...
   
   
   
   
     

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: ozone-issues-unsubscribe@hadoop.apache.org
For additional commands, e-mail: ozone-issues-help@hadoop.apache.org