You are viewing a plain text version of this content. The canonical link for it is here.

Posted to jira@kafka.apache.org by GitBox <gi...@apache.org> on 2020/12/10 20:06:39 UTC

[GitHub] [kafka] ijuma commented on a change in pull request #9728: MINOR: make sure all dir jobs are completed

ijuma commented on a change in pull request #9728:
URL: https://github.com/apache/kafka/pull/9728#discussion_r540461670



##########
File path: core/src/main/scala/kafka/log/LogManager.scala
##########
@@ -435,6 +436,20 @@ class LogManager(logDirs: Seq[File],
       cleaner.startup()
   }
 
+  /**
+   * wait all jobs to complete
+   * @param jobs jobs
+   * @return true if all pass. Otherwise, false
+   */
+  private[log] def allPass(jobs: Seq[Future[_]]): Boolean = {

Review comment:
       The name makes this look generic, but it's not. The logging is very specific. I would change the name to be specific.




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org