You are viewing a plain text version of this content. The canonical link for it is here.

Posted to issues@flink.apache.org by tzulitai <gi...@git.apache.org> on 2016/09/03 18:55:47 UTC

[GitHub] flink pull request #2470: [FLINK-4559][kinesis-connector] Fix AWSUtil.getCre...

GitHub user tzulitai opened a pull request:

    https://github.com/apache/flink/pull/2470

    [FLINK-4559][kinesis-connector] Fix AWSUtil.getCredentialsProvider() to not return null

    Let `AWSUtil#getCredentialsProvider` return a `DefaultAWSCredentialsProviderChain` instead of `null` when
    `AWS_CREDENTIALS_PROVIDER` config is set to `AUTO`.
    
    This mainly fixes the Kinesis producer to correctly get credentials when using the `AUTO` option.

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/tzulitai/flink FLINK-4559

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/flink/pull/2470.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #2470
    
----
commit 7b86137672a4bdec7d67108bf423ef10269ddfa7
Author: Tzu-Li (Gordon) Tai <tz...@apache.org>
Date:   2016-09-03T17:37:39Z

    [FLINK-4559][kinesis-connector] Fix AWSUtil.getCredentialsProvider() to not return null
    
    Return a DefaultAWSCredentialsProviderChain instead of null when
    AWS_CREDENTIALS_PROVIDER config is set to "AUTO"

----


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] flink issue #2470: [FLINK-4559][kinesis-connector] Fix AWSUtil.getCredential...

Posted by greghogan <gi...@git.apache.org>.

Github user greghogan commented on the issue:

    https://github.com/apache/flink/pull/2470
  
    Looks good to me.
    
    Should we also create a ticket to make AUTO the default as this checks for credentials in multiple places?
      http://docs.aws.amazon.com/java-sdk/latest/developer-guide/credentials.html


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] flink issue #2470: [FLINK-4559][kinesis-connector] Fix AWSUtil.getCredential...

Posted by tzulitai <gi...@git.apache.org>.

Github user tzulitai commented on the issue:

    https://github.com/apache/flink/pull/2470
  
    Merging ...


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] flink pull request #2470: [FLINK-4559][kinesis-connector] Fix AWSUtil.getCre...

Posted by asfgit <gi...@git.apache.org>.

Github user asfgit closed the pull request at:

    https://github.com/apache/flink/pull/2470


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] flink issue #2470: [FLINK-4559][kinesis-connector] Fix AWSUtil.getCredential...

Posted by tzulitai <gi...@git.apache.org>.

Github user tzulitai commented on the issue:

    https://github.com/apache/flink/pull/2470
  
    Thanks for the review @greghogan.
    I think it makes sense to let `AUTO` be the default, as the usual use case for most AWS users is to auto-detect the credentials delivered to instances by AWS's metadata service. Changing this should not break user code either. Would you like to open the ticket for that?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---