You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@rocketmq.apache.org by "haiyanghan (via GitHub)" <gi...@apache.org> on 2023/05/12 02:10:55 UTC
[GitHub] [rocketmq] haiyanghan opened a new pull request, #6740: Remove redundant variables
haiyanghan opened a new pull request, #6740:
URL: https://github.com/apache/rocketmq/pull/6740
This AtomicInteger variable is meaningless, there is no thread safety issue here, and the variable does not return
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@rocketmq.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [rocketmq] zhouxinyu merged pull request #6740: [ISSUE #6745] Remove redundant variables
Posted by "zhouxinyu (via GitHub)" <gi...@apache.org>.
zhouxinyu merged PR #6740:
URL: https://github.com/apache/rocketmq/pull/6740
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@rocketmq.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [rocketmq] haiyanghan commented on pull request #6740: [ISSUE #6745] Remove redundant variables
Posted by "haiyanghan (via GitHub)" <gi...@apache.org>.
haiyanghan commented on PR #6740:
URL: https://github.com/apache/rocketmq/pull/6740#issuecomment-1545500079
@mxsm PTAL
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@rocketmq.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [rocketmq] codecov-commenter commented on pull request #6740: Remove redundant variables
Posted by "codecov-commenter (via GitHub)" <gi...@apache.org>.
codecov-commenter commented on PR #6740:
URL: https://github.com/apache/rocketmq/pull/6740#issuecomment-1545023539
## [Codecov](https://app.codecov.io/gh/apache/rocketmq/pull/6740?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
> Merging [#6740](https://app.codecov.io/gh/apache/rocketmq/pull/6740?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (1e5f8f9) into [develop](https://app.codecov.io/gh/apache/rocketmq/commit/9d411cf04a695e7a3f41036e8377b0aa544d754d?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (9d411cf) will **decrease** coverage by `0.02%`.
> The diff coverage is `100.00%`.
```diff
@@ Coverage Diff @@
## develop #6740 +/- ##
=============================================
- Coverage 42.85% 42.84% -0.02%
Complexity 9002 9002
=============================================
Files 1113 1113
Lines 78615 78614 -1
Branches 10229 10229
=============================================
- Hits 33692 33683 -9
+ Misses 40701 40699 -2
- Partials 4222 4232 +10
```
| [Impacted Files](https://app.codecov.io/gh/apache/rocketmq/pull/6740?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | |
|---|---|---|
| [...client/consumer/store/RemoteBrokerOffsetStore.java](https://app.codecov.io/gh/apache/rocketmq/pull/6740?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-Y2xpZW50L3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9yb2NrZXRtcS9jbGllbnQvY29uc3VtZXIvc3RvcmUvUmVtb3RlQnJva2VyT2Zmc2V0U3RvcmUuamF2YQ==) | `68.75% <100.00%> (-0.28%)` | :arrow_down: |
... and [23 files with indirect coverage changes](https://app.codecov.io/gh/apache/rocketmq/pull/6740/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
:mega: We’re building smart automated test selection to slash your CI/CD build times. [Learn more](https://about.codecov.io/iterative-testing/?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@rocketmq.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [rocketmq] haiyanghan commented on pull request #6740: Remove redundant variables
Posted by "haiyanghan (via GitHub)" <gi...@apache.org>.
haiyanghan commented on PR #6740:
URL: https://github.com/apache/rocketmq/pull/6740#issuecomment-1545469904
> Hi @haiyanghan Pleas link to issue.
ok
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@rocketmq.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [rocketmq] haiyanghan commented on pull request #6740: [ISSUE #6745] Remove redundant variables
Posted by "haiyanghan (via GitHub)" <gi...@apache.org>.
haiyanghan commented on PR #6740:
URL: https://github.com/apache/rocketmq/pull/6740#issuecomment-1545492485
[issue](https://github.com/apache/rocketmq/issues/6745)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@rocketmq.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org