You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@cloudstack.apache.org by GitBox <gi...@apache.org> on 2021/03/03 07:04:37 UTC

[GitHub] [cloudstack] utchoang opened a new pull request #4744: UI: Fix update template permission with different domain

utchoang opened a new pull request #4744:
URL: https://github.com/apache/cloudstack/pull/4744


   ### Description
   
   Fixes https://github.com/apache/cloudstack/issues/4031
   <!--- Describe your changes in DETAIL - And how has behaviour functionally changed. -->
   
   <!-- For new features, provide link to FS, dev ML discussion etc. -->
   <!-- In case of bug fix, the expected and actual behaviours, steps to reproduce. -->
   
   <!-- When "Fixes: #<id>" is specified, the issue/PR will automatically be closed when this PR gets merged -->
   <!-- For addressing multiple issues/PRs, use multiple "Fixes: #<id>" -->
   <!-- Fixes: # -->
   
   <!--- ********************************************************************************* -->
   <!--- NOTE: AUTOMATATION USES THE DESCRIPTIONS TO SET LABELS AND PRODUCE DOCUMENTATION. -->
   <!--- PLEASE PUT AN 'X' in only **ONE** box -->
   <!--- ********************************************************************************* -->
   
   ### Types of changes
   
   - [ ] Breaking change (fix or feature that would cause existing functionality to change)
   - [ ] New feature (non-breaking change which adds functionality)
   - [x] Bug fix (non-breaking change which fixes an issue)
   - [ ] Enhancement (improves an existing feature and functionality)
   - [ ] Cleanup (Code refactoring and cleanup, that may add test cases)
   
   ### Feature/Enhancement Scale or Bug Severity
   
   #### Feature/Enhancement Scale
   
   - [ ] Major
   - [x] Minor
   
   #### Bug Severity
   
   - [ ] BLOCKER
   - [ ] Critical
   - [ ] Major
   - [x] Minor
   - [ ] Trivial
   
   
   ### Screenshots (if appropriate):
   
   
   ### How Has This Been Tested?
   <!-- Please describe in detail how you tested your changes. -->
   <!-- Include details of your testing environment, and the tests you ran to -->
   <!-- see how your change affects other areas of the code, etc. -->
   
   
   <!-- Please read the [CONTRIBUTING](https://github.com/apache/cloudstack/blob/master/CONTRIBUTING.md) document -->
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [cloudstack] DaanHoogland commented on pull request #4744: UI: Fix update template permission with different domain

Posted by GitBox <gi...@apache.org>.
DaanHoogland commented on pull request #4744:
URL: https://github.com/apache/cloudstack/pull/4744#issuecomment-803908214


   > LGTM on the change but I'm not completely sure if the linked issue will be fixed
   
   agree @shwstppr . @nvazquez ping, can you check?


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [cloudstack] utchoang commented on a change in pull request #4744: UI: Fix update template permission with different domain

Posted by GitBox <gi...@apache.org>.
utchoang commented on a change in pull request #4744:
URL: https://github.com/apache/cloudstack/pull/4744#discussion_r596587906



##########
File path: ui/src/views/image/UpdateTemplateIsoPermissions.vue
##########
@@ -164,7 +164,7 @@ export default {
     fetchAccounts () {
       this.loading = true
       api('listAccounts', {
-        listall: true
+        domainid: this.resource.domainid

Review comment:
       Adding `isrecursive` will display the subdomain accounts, but when updating permission for those accounts, an error will arise. So I don't think it's necessary. What do you think?
   ![image](https://user-images.githubusercontent.com/13766648/111583323-cca0f980-87ee-11eb-9e5b-9cd80109917c.png)
   ![image](https://user-images.githubusercontent.com/13766648/111583375-e3475080-87ee-11eb-9a47-c04d07c856fe.png)
   ![image](https://user-images.githubusercontent.com/13766648/111583447-07a32d00-87ef-11eb-928a-20e662d6a3f1.png)
   ping @shwstppr 




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [cloudstack] rhtyd merged pull request #4744: UI: Fix update template permission with different domain

Posted by GitBox <gi...@apache.org>.
rhtyd merged pull request #4744:
URL: https://github.com/apache/cloudstack/pull/4744


   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [cloudstack] utchoang commented on pull request #4744: UI: Fix update template permission with different domain

Posted by GitBox <gi...@apache.org>.
utchoang commented on pull request #4744:
URL: https://github.com/apache/cloudstack/pull/4744#issuecomment-789489837


   @blueorangutan ui


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [cloudstack] utchoang commented on a change in pull request #4744: UI: Fix update template permission with different domain

Posted by GitBox <gi...@apache.org>.
utchoang commented on a change in pull request #4744:
URL: https://github.com/apache/cloudstack/pull/4744#discussion_r596587906



##########
File path: ui/src/views/image/UpdateTemplateIsoPermissions.vue
##########
@@ -164,7 +164,7 @@ export default {
     fetchAccounts () {
       this.loading = true
       api('listAccounts', {
-        listall: true
+        domainid: this.resource.domainid

Review comment:
       Adding `isrecursive` will display the subdomain accounts, but when authorizing those accounts, an error will arise. So I don't think it's necessary. What do you think?
   ![image](https://user-images.githubusercontent.com/13766648/111583323-cca0f980-87ee-11eb-9e5b-9cd80109917c.png)
   ![image](https://user-images.githubusercontent.com/13766648/111583375-e3475080-87ee-11eb-9a47-c04d07c856fe.png)
   ![image](https://user-images.githubusercontent.com/13766648/111583447-07a32d00-87ef-11eb-928a-20e662d6a3f1.png)
   




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [cloudstack] utchoang commented on a change in pull request #4744: UI: Fix update template permission with different domain

Posted by GitBox <gi...@apache.org>.
utchoang commented on a change in pull request #4744:
URL: https://github.com/apache/cloudstack/pull/4744#discussion_r596587906



##########
File path: ui/src/views/image/UpdateTemplateIsoPermissions.vue
##########
@@ -164,7 +164,7 @@ export default {
     fetchAccounts () {
       this.loading = true
       api('listAccounts', {
-        listall: true
+        domainid: this.resource.domainid

Review comment:
       Adding `isrecursive` will display the subdomain accounts, but when updating permission for those accounts, an error will arise. So I don't think it's necessary. What do you think?
   ![image](https://user-images.githubusercontent.com/13766648/111583323-cca0f980-87ee-11eb-9e5b-9cd80109917c.png)
   ![image](https://user-images.githubusercontent.com/13766648/111583375-e3475080-87ee-11eb-9a47-c04d07c856fe.png)
   ![image](https://user-images.githubusercontent.com/13766648/111583447-07a32d00-87ef-11eb-928a-20e662d6a3f1.png)
   




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [cloudstack] shwstppr commented on a change in pull request #4744: UI: Fix update template permission with different domain

Posted by GitBox <gi...@apache.org>.
shwstppr commented on a change in pull request #4744:
URL: https://github.com/apache/cloudstack/pull/4744#discussion_r598449976



##########
File path: ui/src/views/image/UpdateTemplateIsoPermissions.vue
##########
@@ -164,7 +164,7 @@ export default {
     fetchAccounts () {
       this.loading = true
       api('listAccounts', {
-        listall: true
+        domainid: this.resource.domainid

Review comment:
       @utchoang then it makes sense to just use just domain filtering.
   But I still feel the original issue is something different. @nvazquez can comment better




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [cloudstack] DaanHoogland commented on pull request #4744: UI: Fix update template permission with different domain

Posted by GitBox <gi...@apache.org>.
DaanHoogland commented on pull request #4744:
URL: https://github.com/apache/cloudstack/pull/4744#issuecomment-791488688


   ping @nvazquez can you see if this fixes your issue #4031?


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [cloudstack] shwstppr commented on a change in pull request #4744: UI: Fix update template permission with different domain

Posted by GitBox <gi...@apache.org>.
shwstppr commented on a change in pull request #4744:
URL: https://github.com/apache/cloudstack/pull/4744#discussion_r596572244



##########
File path: ui/src/views/image/UpdateTemplateIsoPermissions.vue
##########
@@ -164,7 +164,7 @@ export default {
     fetchAccounts () {
       this.loading = true
       api('listAccounts', {
-        listall: true
+        domainid: this.resource.domainid

Review comment:
       ```suggestion
           domainid: this.resource.domainid,
           isrecursive: true
   ```




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [cloudstack] blueorangutan commented on pull request #4744: UI: Fix update template permission with different domain

Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #4744:
URL: https://github.com/apache/cloudstack/pull/4744#issuecomment-789493588


   UI build: :heavy_check_mark:
   Live QA URL: http://qa.cloudstack.cloud:8080/client/pr/4744 (JID-3845)


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [cloudstack] blueorangutan commented on pull request #4744: UI: Fix update template permission with different domain

Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #4744:
URL: https://github.com/apache/cloudstack/pull/4744#issuecomment-805561337


   UI build: :heavy_check_mark:
   Live QA URL: http://qa.cloudstack.cloud:8080/client/pr/4744 (SL-JID-57)


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [cloudstack] blueorangutan commented on pull request #4744: UI: Fix update template permission with different domain

Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #4744:
URL: https://github.com/apache/cloudstack/pull/4744#issuecomment-789490159


   @utchoang a Jenkins job has been kicked to build UI QA env. I'll keep you posted as I make progress.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org