You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@storm.apache.org by ppoulosk <gi...@git.apache.org> on 2016/03/08 16:36:32 UTC
[GitHub] storm pull request: [STORM-1612] Remove hardcoded port, and unrefe...
GitHub user ppoulosk opened a pull request:
https://github.com/apache/storm/pull/1193
[STORM-1612] Remove hardcoded port, and unreferenced global from netty_unit_test
Just remove the unnecessary hardcoded port, so that the call will return an ephemeral port, and remove unused global "port".
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/ppoulosk/storm STORM-1612
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/storm/pull/1193.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #1193
----
commit 54a501e04254b06baf58e86c4767c925ce7f9d80
Author: Paul Poulosky <pp...@thenperfect-lm.champ.corp.yahoo.com>
Date: 2016-03-08T15:29:15Z
Remove hardcoded port, and unreferenced global from netty_unit_test
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] storm pull request: [STORM-1612] Remove hardcoded port, and unrefe...
Posted by ppoulosk <gi...@git.apache.org>.
Github user ppoulosk commented on the pull request:
https://github.com/apache/storm/pull/1193#issuecomment-193869016
It falls back to ephemeral if preferred is bound, so this is not needed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] storm pull request: [STORM-1612] Remove hardcoded port, and unrefe...
Posted by ppoulosk <gi...@git.apache.org>.
Github user ppoulosk closed the pull request at:
https://github.com/apache/storm/pull/1193
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---