You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues-all@impala.apache.org by "ASF subversion and git services (JIRA)" <ji...@apache.org> on 2019/02/15 05:00:00 UTC
[jira] [Commented] (IMPALA-8194)
TestPauseMonitor.test_jvm_pause_monitor_logs_entries needs to wait longer
to see output
[ https://issues.apache.org/jira/browse/IMPALA-8194?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16768939#comment-16768939 ]
ASF subversion and git services commented on IMPALA-8194:
---------------------------------------------------------
Commit 7cee01d1ba7ab6018bf6d7e4d90f4758fd458ce0 in impala's branch refs/heads/master from Andrew Sherman
[ https://gitbox.apache.org/repos/asf?p=impala.git;h=7cee01d ]
IMPALA-8194: wait longer to detect JVM pause in TestPauseMonitor.
The test 'test_jvm_pause_monitor_logs_entries' stops and starts an
impalad, and confirms that that the JVM pause monitor detects the pause
by looking for a specific message in the log. In a test run the test
failed to find the correct message after sleeping for 1.2 seconds.
Because the test notes the last message that it sees in the log, we can
observe that the test would have found the correct message if it had
waited for just a few more milliseconds.
This change increases the time that the test waits to 2 seconds.
TESTING:
Ran end-to-end tests cleanly and checked that
test_jvm_pause_monitor_logs_entries ran OK.
Change-Id: I735c0c0ecfd3a9099c9cef332c5e79854bec7b8d
Reviewed-on: http://gerrit.cloudera.org:8080/12475
Reviewed-by: Impala Public Jenkins <im...@cloudera.com>
Tested-by: Impala Public Jenkins <im...@cloudera.com>
> TestPauseMonitor.test_jvm_pause_monitor_logs_entries needs to wait longer to see output
> ---------------------------------------------------------------------------------------
>
> Key: IMPALA-8194
> URL: https://issues.apache.org/jira/browse/IMPALA-8194
> Project: IMPALA
> Issue Type: Bug
> Reporter: Andrew Sherman
> Assignee: Andrew Sherman
> Priority: Critical
> Labels: broken-build, flaky-test
>
> TestPauseMonitor.test_jvm_pause_monitor_logs_entries complains:
> {quote}
> FAIL custom_cluster/test_pause_monitor.py::TestPauseMonitor::()::test_jvm_pause_monitor_logs_entries
> =================================== FAILURES ===================================
> _____________ TestPauseMonitor.test_jvm_pause_monitor_logs_entries _____________
> custom_cluster/test_pause_monitor.py:38: in test_jvm_pause_monitor_logs_entries
> self.assert_impalad_log_contains('INFO', "Detected pause in JVM or host machine")
> common/custom_cluster_test_suite.py:216: in assert_impalad_log_contains
> self.assert_log_contains("impalad", level, line_regex, expected_count)
> common/custom_cluster_test_suite.py:248: in assert_log_contains
> (expected_count, log_file_path, line_regex, found, line)
> E AssertionError: Expected 1 lines in file /data0/jenkins/workspace/xxx/repos/Impala/logs/custom_cluster_tests/impalad.impala-xxx.jenkins.log.INFO.20190211-183351.2092 matching regex 'Detected pause in JVM or host machine', but found 0 lines. Last line was:
> E I0211 18:34:03.563254 2392 thrift-util.cc:113] TAcceptQueueServer client died: write() send(): Broken pipe
> {quote}
> The actual log (archived later) contains:
> {quote}
> I0211 18:34:03.563254 2392 thrift-util.cc:113] TAcceptQueueServer client died: write() send(): Broken pipe
> I0211 18:34:03.565459 2164 JvmPauseMonitor.java:187] Detected pause in JVM or host machine (eg GC): pause of approximately 4550ms
> No GCs detected
> {quote}
> so if test_jvm_pause_monitor_logs_entries had waited for 3ms more it would have seen the line it was looking for (assuming the simplest explanation).
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-all-unsubscribe@impala.apache.org
For additional commands, e-mail: issues-all-help@impala.apache.org