You are viewing a plain text version of this content. The canonical link for it is here.
Posted to github@arrow.apache.org by "paleolimbot (via GitHub)" <gi...@apache.org> on 2026/06/04 02:18:32 UTC
[PR] fix: Eliminate warnings for gcc16 and _FORTIFY_SOURCE=3 for snprintf [arrow-nanoarrow]
paleolimbot opened a new pull request, #892:
URL: https://github.com/apache/arrow-nanoarrow/pull/892
The `ArrowSchemaToString()` function used `snprintf(NULL, 0, "...")` to calculate final buffer sizes; however, this led to warnings (either because all NULLs are bad in this case or because the compiler couldn't prove that `n` was zero). This led to CRAN warnings for nanoarrow and all packages that vendored it because CRAN compiles on gcc16. Opus 4.5 seemed to suggest _FORTIFY_SOURCE=3 rejected all null inputs to snprintf, so this PR removes them.
In the process I tidied up the printing a bit since it was hard to follow.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] fix: Eliminate warnings for gcc16 and _FORTIFY_SOURCE=3 for snprintf [arrow-nanoarrow]
Posted by "paleolimbot (via GitHub)" <gi...@apache.org>.
paleolimbot merged PR #892:
URL: https://github.com/apache/arrow-nanoarrow/pull/892
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] fix: Eliminate warnings for gcc16 and _FORTIFY_SOURCE=3 for snprintf [arrow-nanoarrow]
Posted by "codecov-commenter (via GitHub)" <gi...@apache.org>.
codecov-commenter commented on PR #892:
URL: https://github.com/apache/arrow-nanoarrow/pull/892#issuecomment-4618399204
## [Codecov](https://app.codecov.io/gh/apache/arrow-nanoarrow/pull/892?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report
:white_check_mark: All modified and coverable lines are covered by tests.
:white_check_mark: Project coverage is 78.59%. Comparing base ([`f11d517`](https://app.codecov.io/gh/apache/arrow-nanoarrow/commit/f11d5170853c976d9ea736d5b27b97226cfd7358?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)) to head ([`6511d09`](https://app.codecov.io/gh/apache/arrow-nanoarrow/commit/6511d09cdd84a61fd73a52c5773e1ebf2df9ccb8?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)).
:warning: Report is 52 commits behind head on main.
<details><summary>Additional details and impacted files</summary>
```diff
@@ Coverage Diff @@
## main #892 +/- ##
==========================================
- Coverage 79.96% 78.59% -1.38%
==========================================
Files 105 106 +1
Lines 15461 16128 +667
Branches 1738 1858 +120
==========================================
+ Hits 12364 12675 +311
- Misses 1998 2286 +288
- Partials 1099 1167 +68
```
</details>
[:umbrella: View full report in Codecov by Harness](https://app.codecov.io/gh/apache/arrow-nanoarrow/pull/892?dropdown=coverage&src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache).
:loudspeaker: Have feedback on the report? [Share it here](https://about.codecov.io/codecov-pr-comment-feedback/?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache).
<details><summary> :rocket: New features to boost your workflow: </summary>
- :snowflake: [Test Analytics](https://docs.codecov.com/docs/test-analytics): Detect flaky tests, report on failures, and find test suite problems.
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org