You are viewing a plain text version of this content. The canonical link for it is here.
Posted to github@arrow.apache.org by GitBox <gi...@apache.org> on 2020/08/19 02:50:00 UTC

[GitHub] [arrow] jorgecarleitao opened a new pull request #8000: ARROW-9793: [Rust] [DataFusion] Fixed unit tests

jorgecarleitao opened a new pull request #8000:
URL: https://github.com/apache/arrow/pull/8000


   FYI @andygrove 
   
   We did not rebased against master and run the tests, which caused some API incompatibilities.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [arrow] github-actions[bot] commented on pull request #8000: ARROW-9793: [Rust] [DataFusion] Fixed unit tests

Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on pull request #8000:
URL: https://github.com/apache/arrow/pull/8000#issuecomment-675823978


   https://issues.apache.org/jira/browse/ARROW-9793


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [arrow] jorgecarleitao commented on a change in pull request #8000: ARROW-9793: [Rust] [DataFusion] Fixed unit tests

Posted by GitBox <gi...@apache.org>.
jorgecarleitao commented on a change in pull request #8000:
URL: https://github.com/apache/arrow/pull/8000#discussion_r472617010



##########
File path: rust/datafusion/src/optimizer/filter_push_down.rs
##########
@@ -370,10 +368,9 @@ mod tests {
         let plan = LogicalPlanBuilder::from(&table_scan)
             .aggregate(
                 vec![col("a")],
-                vec![aggregate_expr("SUM", col("b"), DataType::Int32)
-                    .alias("total_salary")],
+                vec![aggregate_expr("SUM", col("b")).alias("total_salary")],
             )?
-            .filter(col("a").gt(Expr::Literal(ScalarValue::Int64(10))))?

Review comment:
       this was a simplification, so that the tests do not need to use `DataType` nor `ScalarValue`.




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [arrow] andygrove closed pull request #8000: ARROW-9793: [Rust] [DataFusion] Fixed unit tests

Posted by GitBox <gi...@apache.org>.
andygrove closed pull request #8000:
URL: https://github.com/apache/arrow/pull/8000


   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org