[jira] [Resolved] (HDFS-16042) DatanodeAdminMonitor scan should be delay based

["Jim Brennan (Jira)" <ji...@apache.org>]

     [ https://issues.apache.org/jira/browse/HDFS-16042?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Jim Brennan resolved HDFS-16042.
--------------------------------
    Fix Version/s: 3.4.0
       Resolution: Fixed

Thanks for the contribution [~ahussein]!  [~kihwal] committed this to trunk.


> DatanodeAdminMonitor scan should be delay based
> -----------------------------------------------
>
>                 Key: HDFS-16042
>                 URL: https://issues.apache.org/jira/browse/HDFS-16042
>             Project: Hadoop HDFS
>          Issue Type: Bug
>          Components: datanode
>            Reporter: Ahmed Hussein
>            Assignee: Ahmed Hussein
>            Priority: Major
>              Labels: pull-request-available
>             Fix For: 3.4.0
>
>          Time Spent: 1.5h
>  Remaining Estimate: 0h
>
> In {{DatanodeAdminManager.activate()}}, the Monitor task is scheduled with a fixed rate, ie. the period is from start1 -> start2.  
> {code:java}
> executor.scheduleAtFixedRate(monitor, intervalSecs, intervalSecs,
>    TimeUnit.SECONDS);
> {code}
> According to Java API docs for {{scheduleAtFixedRate}},
> {quote}If any execution of this task takes longer than its period, then subsequent executions may start late, but will not concurrently execute.{quote}
> It should be a fixed delay so it's end1 -> start1.
>  



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

---------------------------------------------------------------------
To unsubscribe, e-mail: hdfs-dev-unsubscribe@hadoop.apache.org
For additional commands, e-mail: hdfs-dev-help@hadoop.apache.org