You are viewing a plain text version of this content. The canonical link for it is here.
Posted to github@arrow.apache.org by "adamreeve (via GitHub)" <gi...@apache.org> on 2024/05/27 03:49:00 UTC

[PR] GH-41806: [GLib][CI] Use vcpkg for C++ dependencies when building GLib libraries with MSVC [arrow]

adamreeve opened a new pull request, #41839:
URL: https://github.com/apache/arrow/pull/41839

   ### Rationale for this change
   
   This is more consistent as vcpkg is now used for both the Arrow C++ dependencies and GLib library dependencies, and also fixes building arrow-flight-glib and arrow-flight-sql-glib which previously failed due to a missing zlib dependency.
   
   ### What changes are included in this PR?
   
   * Configure the MSVC GLib build to use VCPKG as the dependency source for the C++ build
   * Configure GitHub packages based vcpkg caching (see https://learn.microsoft.com/en-us/vcpkg/users/binarycaching#quickstart-github)
   * Enable building Flight and Flight SQL
   
   ### Are these changes tested?
   
   NA
   
   ### Are there any user-facing changes?
   
   No
   
   Because GitHub packages is being used for caching, this will start creating GitHub packages that are visible in the main page of the Arrow GitHub repository by default. Eg. you can see them in the right panel on the crossbow repo which also runs tasks that use GitHub packages for vcpkg caching: https://github.com/ursacomputing/crossbow.
   
   The Arrow repository doesn't currently publish any packages, so it would probably be best to hide these by default to avoid confusing users and adding unnecessary noise. Someone with admin privileges on the Arrow GitHub repository would need to click the cog on the home page and hide this section:
   ![hide_packages](https://github.com/apache/arrow/assets/626438/69e1be77-65e7-4a17-8e9e-6d7cf90834b5)
   
   If this isn't desirable I could look into other ways of caching instead, eg. using a file based cache combined with GitHub actions cache action, or the experimental GitHub actions cache in vcpkg.
   
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] GH-41806: [GLib][CI] Use vcpkg for C++ dependencies when building GLib libraries with MSVC [arrow]

Posted by "adamreeve (via GitHub)" <gi...@apache.org>.
adamreeve commented on code in PR #41839:
URL: https://github.com/apache/arrow/pull/41839#discussion_r1615808934


##########
.github/workflows/ruby.yml:
##########
@@ -337,13 +340,15 @@ jobs:
       ARROW_WITH_LZ4: OFF
       ARROW_WITH_OPENTELEMETRY: OFF
       ARROW_WITH_SNAPPY: ON
-      ARROW_WITH_ZLIB: OFF
+      ARROW_WITH_ZLIB: ON
       ARROW_WITH_ZSTD: ON
       BOOST_SOURCE: BUNDLED

Review Comment:
   Oh sorry I realise now that this comment is about the BOOST_SOURCE variable, not the ZLIB setting. Yes this should be removed, boost is coming from vcpkg so this shouldn't have any effect and could be confusing.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] GH-41806: [GLib][CI] Use vcpkg for C++ dependencies when building GLib libraries with MSVC [arrow]

Posted by "kou (via GitHub)" <gi...@apache.org>.
kou commented on code in PR #41839:
URL: https://github.com/apache/arrow/pull/41839#discussion_r1615444868


##########
.github/workflows/ruby.yml:
##########
@@ -387,11 +392,28 @@ jobs:
         env:
           # We can invalidate the current cache by updating this.
           CACHE_VERSION: "2024-05-09"
+      - name: Setup NuGet credentials for vcpkg caching
+        shell: bash
+        run: |
+          `./vcpkg/vcpkg.exe fetch nuget | tail -n 1` \

Review Comment:
   ```suggestion
             $(vcpkg/vcpkg.exe fetch nuget | tail -n 1) \
   ```



##########
cpp/cmake_modules/Usevcpkg.cmake:
##########
@@ -249,4 +249,7 @@ if(CMAKE_HOST_WIN32)
   set(ZSTD_MSVC_STATIC_LIB_SUFFIX
       ""
       CACHE STRING "")
+  set(utf8proc_MSVC_STATIC_LIB_SUFFIX
+      ""
+      CACHE STRING "")

Review Comment:
   Could you keep this list in alphabetical order?



##########
.github/workflows/ruby.yml:
##########
@@ -387,11 +392,28 @@ jobs:
         env:
           # We can invalidate the current cache by updating this.
           CACHE_VERSION: "2024-05-09"
+      - name: Setup NuGet credentials for vcpkg caching
+        shell: bash
+        run: |
+          `./vcpkg/vcpkg.exe fetch nuget | tail -n 1` \
+            sources add \
+            -source "https://nuget.pkg.github.com/$GITHUB_REPOSITORY_OWNER/index.json" \
+            -storepasswordincleartext \
+            -name "GitHub" \
+            -username "$GITHUB_REPOSITORY_OWNER" \
+            -password "${{ secrets.GITHUB_TOKEN }}"
+          `./vcpkg/vcpkg.exe fetch nuget | tail -n 1` \
+            setapikey "${{ secrets.GITHUB_TOKEN }}" \
+            -source "https://nuget.pkg.github.com/$GITHUB_REPOSITORY_OWNER/index.json"
+      - name: Build C++ VCPKG dependencies
+        shell: cmd
+        run: |
+          vcpkg\vcpkg.exe install --triplet x64-windows --x-manifest-root cpp --x-install-root build\cpp\vcpkg_installed
       - name: Build C++
         shell: cmd
         run: |
           call "C:\Program Files (x86)\Microsoft Visual Studio\2019\Enterprise\VC\Auxiliary\Build\vcvarsall.bat" x64
-          bash -c "ci/scripts/cpp_build.sh $(pwd) $(pwd)/build"
+          bash -c "VCPKG_ROOT=\"$(pwd)/vcpkg\" ci/scripts/cpp_build.sh $(pwd) $(pwd)/build"

Review Comment:
   Can we set this in `env:` something like `VCPKG_ROOT: "${{ github.workspace }}/vcpkg"`?
   (Do we need UNIX style path here?)



##########
.github/workflows/ruby.yml:
##########
@@ -387,11 +392,28 @@ jobs:
         env:
           # We can invalidate the current cache by updating this.
           CACHE_VERSION: "2024-05-09"
+      - name: Setup NuGet credentials for vcpkg caching
+        shell: bash
+        run: |
+          `./vcpkg/vcpkg.exe fetch nuget | tail -n 1` \
+            sources add \
+            -source "https://nuget.pkg.github.com/$GITHUB_REPOSITORY_OWNER/index.json" \
+            -storepasswordincleartext \
+            -name "GitHub" \
+            -username "$GITHUB_REPOSITORY_OWNER" \
+            -password "${{ secrets.GITHUB_TOKEN }}"
+          `./vcpkg/vcpkg.exe fetch nuget | tail -n 1` \

Review Comment:
   ```suggestion
             $(vcpkg/vcpkg.exe fetch nuget | tail -n 1) \
   ```



##########
.github/workflows/ruby.yml:
##########
@@ -337,13 +340,15 @@ jobs:
       ARROW_WITH_LZ4: OFF
       ARROW_WITH_OPENTELEMETRY: OFF
       ARROW_WITH_SNAPPY: ON
-      ARROW_WITH_ZLIB: OFF
+      ARROW_WITH_ZLIB: ON
       ARROW_WITH_ZSTD: ON
       BOOST_SOURCE: BUNDLED

Review Comment:
   Can we remove this?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] GH-41806: [GLib][CI] Use vcpkg for C++ dependencies when building GLib libraries with MSVC [arrow]

Posted by "adamreeve (via GitHub)" <gi...@apache.org>.
adamreeve commented on code in PR #41839:
URL: https://github.com/apache/arrow/pull/41839#discussion_r1615808934


##########
.github/workflows/ruby.yml:
##########
@@ -337,13 +340,15 @@ jobs:
       ARROW_WITH_LZ4: OFF
       ARROW_WITH_OPENTELEMETRY: OFF
       ARROW_WITH_SNAPPY: ON
-      ARROW_WITH_ZLIB: OFF
+      ARROW_WITH_ZLIB: ON
       ARROW_WITH_ZSTD: ON
       BOOST_SOURCE: BUNDLED

Review Comment:
   Oh sorry I realise now that this comment is about the BOOST_SOURCE variable, not the ZLIB setting. Yes this should be removed, boost is coming from vcpkg so this shouldn't have any effect.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] GH-41806: [GLib][CI] Use vcpkg for C++ dependencies when building GLib libraries with MSVC [arrow]

Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #41839:
URL: https://github.com/apache/arrow/pull/41839#issuecomment-2132590595

   :warning: GitHub issue #41806 **has been automatically assigned in GitHub** to PR creator.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] GH-41806: [GLib][CI] Use vcpkg for C++ dependencies when building GLib libraries with MSVC [arrow]

Posted by "kou (via GitHub)" <gi...@apache.org>.
kou commented on code in PR #41839:
URL: https://github.com/apache/arrow/pull/41839#discussion_r1616446626


##########
.github/workflows/ruby.yml:
##########
@@ -387,6 +392,23 @@ jobs:
         env:
           # We can invalidate the current cache by updating this.
           CACHE_VERSION: "2024-05-09"
+      - name: Setup NuGet credentials for vcpkg caching
+        shell: bash
+        run: |
+          $(vcpkg/vcpkg.exe fetch nuget | tail -n 1) \
+            sources add \
+            -source "https://nuget.pkg.github.com/$GITHUB_REPOSITORY_OWNER/index.json" \
+            -storepasswordincleartext \
+            -name "GitHub" \
+            -username "$GITHUB_REPOSITORY_OWNER" \
+            -password "${{ secrets.GITHUB_TOKEN }}"
+          $(vcpkg/vcpkg.exe fetch nuget | tail -n 1) \
+            setapikey "${{ secrets.GITHUB_TOKEN }}" \
+            -source "https://nuget.pkg.github.com/$GITHUB_REPOSITORY_OWNER/index.json"
+      - name: Build C++ VCPKG dependencies

Review Comment:
   ```suggestion
         - name: Build C++ vcpkg dependencies
   ```



##########
.github/workflows/ruby.yml:
##########
@@ -387,6 +392,23 @@ jobs:
         env:
           # We can invalidate the current cache by updating this.
           CACHE_VERSION: "2024-05-09"
+      - name: Setup NuGet credentials for vcpkg caching
+        shell: bash
+        run: |
+          $(vcpkg/vcpkg.exe fetch nuget | tail -n 1) \
+            sources add \
+            -source "https://nuget.pkg.github.com/$GITHUB_REPOSITORY_OWNER/index.json" \
+            -storepasswordincleartext \
+            -name "GitHub" \
+            -username "$GITHUB_REPOSITORY_OWNER" \
+            -password "${{ secrets.GITHUB_TOKEN }}"
+          $(vcpkg/vcpkg.exe fetch nuget | tail -n 1) \
+            setapikey "${{ secrets.GITHUB_TOKEN }}" \
+            -source "https://nuget.pkg.github.com/$GITHUB_REPOSITORY_OWNER/index.json"
+      - name: Build C++ VCPKG dependencies
+        shell: cmd

Review Comment:
   Can we remove this? (Can we use PowerShell here?)
   
   ```suggestion
   ```



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] GH-41806: [GLib][CI] Use vcpkg for C++ dependencies when building GLib libraries with MSVC [arrow]

Posted by "kou (via GitHub)" <gi...@apache.org>.
kou merged PR #41839:
URL: https://github.com/apache/arrow/pull/41839


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] GH-41806: [GLib][CI] Use vcpkg for C++ dependencies when building GLib libraries with MSVC [arrow]

Posted by "conbench-apache-arrow[bot] (via GitHub)" <gi...@apache.org>.
conbench-apache-arrow[bot] commented on PR #41839:
URL: https://github.com/apache/arrow/pull/41839#issuecomment-2144079417

   After merging your PR, Conbench analyzed the 4 benchmarking runs that have been run so far on merge-commit 44070eb99f0db907e1cf7a445bf7c6fea78e17fe.
   
   There were 3 benchmark results indicating a performance regression:
   
   - Commit Run on `test-mac-arm` at [2024-06-02 22:14:33Z](https://conbench.ursa.dev/compare/runs/eec1d2bee2a748e58067469aa1795f7c...413ef4f42820406eae431c592a21568d/)
     - [`tpch` (R) with engine=arrow, format=native, language=R, memory_map=False, query_id=TPCH-17, scale_factor=1](https://conbench.ursa.dev/compare/benchmarks/0665bb3f3d27764980002b873af94339...0665cf7ceaab742e8000a554fe337662)
     - [`tpch` (R) with engine=arrow, format=native, language=R, memory_map=False, query_id=TPCH-01, scale_factor=1](https://conbench.ursa.dev/compare/benchmarks/0665bb28ce65763d8000aa2b1e4ef950...0665cf65638676048000b2f2e2172022)
   - and 1 more (see the report linked below)
   
   The [full Conbench report](https://github.com/apache/arrow/runs/25710240252) has more details. It also includes information about 6 possible false positives for unstable benchmarks that are known to sometimes produce them.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] GH-41806: [GLib][CI] Use vcpkg for C++ dependencies when building GLib libraries with MSVC [arrow]

Posted by "adamreeve (via GitHub)" <gi...@apache.org>.
adamreeve commented on code in PR #41839:
URL: https://github.com/apache/arrow/pull/41839#discussion_r1616447628


##########
.github/workflows/ruby.yml:
##########
@@ -387,6 +392,23 @@ jobs:
         env:
           # We can invalidate the current cache by updating this.
           CACHE_VERSION: "2024-05-09"
+      - name: Setup NuGet credentials for vcpkg caching
+        shell: bash
+        run: |
+          $(vcpkg/vcpkg.exe fetch nuget | tail -n 1) \
+            sources add \
+            -source "https://nuget.pkg.github.com/$GITHUB_REPOSITORY_OWNER/index.json" \
+            -storepasswordincleartext \
+            -name "GitHub" \
+            -username "$GITHUB_REPOSITORY_OWNER" \
+            -password "${{ secrets.GITHUB_TOKEN }}"
+          $(vcpkg/vcpkg.exe fetch nuget | tail -n 1) \
+            setapikey "${{ secrets.GITHUB_TOKEN }}" \
+            -source "https://nuget.pkg.github.com/$GITHUB_REPOSITORY_OWNER/index.json"
+      - name: Build C++ VCPKG dependencies
+        shell: cmd

Review Comment:
   :+1: yes I don't think there's any reason this should need to be cmd



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] GH-41806: [GLib][CI] Use vcpkg for C++ dependencies when building GLib libraries with MSVC [arrow]

Posted by "adamreeve (via GitHub)" <gi...@apache.org>.
adamreeve commented on PR #41839:
URL: https://github.com/apache/arrow/pull/41839#issuecomment-2143923536

   @kou is there anything more needed on this PR? There are a few CI failures after merging from main but these are also failing on main (the c_glib MinGW build and C++ ARM64 build) or look like a transient error (the appveyor build)


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] GH-41806: [GLib][CI] Use vcpkg for C++ dependencies when building GLib libraries with MSVC [arrow]

Posted by "adamreeve (via GitHub)" <gi...@apache.org>.
adamreeve commented on code in PR #41839:
URL: https://github.com/apache/arrow/pull/41839#discussion_r1615796937


##########
.github/workflows/ruby.yml:
##########
@@ -387,11 +392,28 @@ jobs:
         env:
           # We can invalidate the current cache by updating this.
           CACHE_VERSION: "2024-05-09"
+      - name: Setup NuGet credentials for vcpkg caching
+        shell: bash
+        run: |
+          `./vcpkg/vcpkg.exe fetch nuget | tail -n 1` \
+            sources add \
+            -source "https://nuget.pkg.github.com/$GITHUB_REPOSITORY_OWNER/index.json" \
+            -storepasswordincleartext \
+            -name "GitHub" \
+            -username "$GITHUB_REPOSITORY_OWNER" \
+            -password "${{ secrets.GITHUB_TOKEN }}"
+          `./vcpkg/vcpkg.exe fetch nuget | tail -n 1` \
+            setapikey "${{ secrets.GITHUB_TOKEN }}" \
+            -source "https://nuget.pkg.github.com/$GITHUB_REPOSITORY_OWNER/index.json"
+      - name: Build C++ VCPKG dependencies
+        shell: cmd
+        run: |
+          vcpkg\vcpkg.exe install --triplet x64-windows --x-manifest-root cpp --x-install-root build\cpp\vcpkg_installed
       - name: Build C++
         shell: cmd
         run: |
           call "C:\Program Files (x86)\Microsoft Visual Studio\2019\Enterprise\VC\Auxiliary\Build\vcvarsall.bat" x64
-          bash -c "ci/scripts/cpp_build.sh $(pwd) $(pwd)/build"
+          bash -c "VCPKG_ROOT=\"$(pwd)/vcpkg\" ci/scripts/cpp_build.sh $(pwd) $(pwd)/build"

Review Comment:
   Yeah I think the reason I did it like this rather than in env was to use a unix path but I didn't test whether it works OK as a Windows path, I'll check.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] GH-41806: [GLib][CI] Use vcpkg for C++ dependencies when building GLib libraries with MSVC [arrow]

Posted by "adamreeve (via GitHub)" <gi...@apache.org>.
adamreeve commented on PR #41839:
URL: https://github.com/apache/arrow/pull/41839#issuecomment-2133174852

   The binary caching is failing in the CI builds for this PR but this is only because GitHub doesn't allow writing to the packages in a build for a PR from a fork (see https://docs.github.com/en/actions/security-guides/automatic-token-authentication#permissions-for-the-github_token).
   
   Eg. there are log lines like:
   ```
   Uploading binaries for 'vcpkg-cmake-config:x64-windows' to 'NuGet' source "GitHub".
   Pushing NuGet to "GitHub" failed. Use --debug for more information.
   Stored binaries in 0 destinations in 1.9 s.
   ```
   
   The caching does work when I tested it on my fork, eg. see https://github.com/adamreeve/arrow/actions/runs/9253178800/job/25452360216, where the "Build C++ VCPKG dependencies" step took 1 minute rather than 50.
   
   Once this PR is merged to main then any PR builds should be able to read from the cache but won't be able to write to it.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] GH-41806: [GLib][CI] Use vcpkg for C++ dependencies when building GLib libraries with MSVC [arrow]

Posted by "adamreeve (via GitHub)" <gi...@apache.org>.
adamreeve commented on PR #41839:
URL: https://github.com/apache/arrow/pull/41839#issuecomment-2144017910

   👍 thanks


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] GH-41806: [GLib][CI] Use vcpkg for C++ dependencies when building GLib libraries with MSVC [arrow]

Posted by "adamreeve (via GitHub)" <gi...@apache.org>.
adamreeve commented on code in PR #41839:
URL: https://github.com/apache/arrow/pull/41839#discussion_r1615802189


##########
.github/workflows/ruby.yml:
##########
@@ -337,13 +340,15 @@ jobs:
       ARROW_WITH_LZ4: OFF
       ARROW_WITH_OPENTELEMETRY: OFF
       ARROW_WITH_SNAPPY: ON
-      ARROW_WITH_ZLIB: OFF
+      ARROW_WITH_ZLIB: ON
       ARROW_WITH_ZSTD: ON
       BOOST_SOURCE: BUNDLED

Review Comment:
   Yes this is implied by ARROW_WITH_FLIGHT so doesn't need to be set explicitly, I'll remove it



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] GH-41806: [GLib][CI] Use vcpkg for C++ dependencies when building GLib libraries with MSVC [arrow]

Posted by "adamreeve (via GitHub)" <gi...@apache.org>.
adamreeve commented on code in PR #41839:
URL: https://github.com/apache/arrow/pull/41839#discussion_r1615843329


##########
.github/workflows/ruby.yml:
##########
@@ -387,11 +392,28 @@ jobs:
         env:
           # We can invalidate the current cache by updating this.
           CACHE_VERSION: "2024-05-09"
+      - name: Setup NuGet credentials for vcpkg caching
+        shell: bash
+        run: |
+          `./vcpkg/vcpkg.exe fetch nuget | tail -n 1` \
+            sources add \
+            -source "https://nuget.pkg.github.com/$GITHUB_REPOSITORY_OWNER/index.json" \
+            -storepasswordincleartext \
+            -name "GitHub" \
+            -username "$GITHUB_REPOSITORY_OWNER" \
+            -password "${{ secrets.GITHUB_TOKEN }}"
+          `./vcpkg/vcpkg.exe fetch nuget | tail -n 1` \
+            setapikey "${{ secrets.GITHUB_TOKEN }}" \
+            -source "https://nuget.pkg.github.com/$GITHUB_REPOSITORY_OWNER/index.json"
+      - name: Build C++ VCPKG dependencies
+        shell: cmd
+        run: |
+          vcpkg\vcpkg.exe install --triplet x64-windows --x-manifest-root cpp --x-install-root build\cpp\vcpkg_installed
       - name: Build C++
         shell: cmd
         run: |
           call "C:\Program Files (x86)\Microsoft Visual Studio\2019\Enterprise\VC\Auxiliary\Build\vcvarsall.bat" x64
-          bash -c "ci/scripts/cpp_build.sh $(pwd) $(pwd)/build"
+          bash -c "VCPKG_ROOT=\"$(pwd)/vcpkg\" ci/scripts/cpp_build.sh $(pwd) $(pwd)/build"

Review Comment:
   Yes it seems to work fine as a Windows path so I've set it in `env` now



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] GH-41806: [GLib][CI] Use vcpkg for C++ dependencies when building GLib libraries with MSVC [arrow]

Posted by "kou (via GitHub)" <gi...@apache.org>.
kou commented on PR #41839:
URL: https://github.com/apache/arrow/pull/41839#issuecomment-2144017605

   Sorry. I missed this. I've merged.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org