[GitHub] [spark] asl3 commented on a diff in pull request #41606: [WIP] [SPARK-44061] Add assertDFEqual util function

["asl3 (via GitHub)" <gi...@apache.org>]

asl3 commented on code in PR #41606:
URL: https://github.com/apache/spark/pull/41606#discussion_r1251290690


##########
python/pyspark/testing/utils.py:
##########
@@ -209,3 +216,50 @@ def check_error(
         self.assertEqual(
             expected, actual, f"Expected message parameters was '{expected}', got '{actual}'"
         )
+
+
+def assertSparkSchemaEquality(
+    s1: Optional[Union[AtomicType, StructType, str, List[str], Tuple[str, ...]]],
+    s2: Optional[Union[AtomicType, StructType, str, List[str], Tuple[str, ...]]],
+):
+    if s1 != s2:
+        msg = "Schemas are different"
+        raise AssertionError(msg)
+
+
+def assertSparkDFEqual(left: PySparkDataFrame, right: PySparkDataFrame):
+    def assert_rows_equality(rows1, rows2):
+        if rows1 != rows2:
+            raise PySparkAssertionError(

Review Comment:
   @itholic and @HyukjinKwon advised using error classes since this error can be raised in the user space



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org