You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@subversion.apache.org by Blair Zajac <bl...@orcaware.com> on 2013/01/09 23:29:03 UTC
Re: svn commit: r1431072 - in /subversion/trunk/subversion: include/svn_types.h
libsvn_client/copy.c libsvn_ra_serf/commit.c libsvn_subr/named_atomic.c libsvn_subr/stream.c
mod_dav_svn/reports/replay.c svnadmin/svnadmin.c tests/libsvn_subr/mergeinfo-test.c
On 01/09/2013 01:02 PM, julianfoad@apache.org wrote:
> Author: julianfoad
> Date: Wed Jan 9 21:02:33 2013
> New Revision: 1431072
>
> URL: http://svn.apache.org/viewvc?rev=1431072&view=rev
> Log:
> Consistify a few remaining redundant or odd expressions involving boolean
> constants, such as "foo == FALSE" to "!foo" and "number ? FALSE : TRUE" to
> "number != 0". A follow-up to r1431017 and r1431040.
The commit is good and so is the comment on replay.c, but this should
read "number ? TRUE : FALSE" to be correct and match the code.
Blair
Re: svn commit: r1431072 - in /subversion/trunk/subversion: include/svn_types.h libsvn_client/copy.c libsvn_ra_serf/commit.c libsvn_subr/named_atomic.c libsvn_subr/stream.c mod_dav_svn/reports/replay.c svnadmin/svnadmin.c tests/libsvn_subr/mergeinfo-test.c
Posted by Julian Foad <ju...@btopenworld.com>.
Blair Zajac wrote:
> On 01/09/2013 01:02 PM, julianfoad@apache.org wrote:
>> Log:
>> Consistify a few remaining redundant or odd expressions involving boolean
>> constants, such as "foo == FALSE" to "!foo" and "number ? FALSE : TRUE" to
>> "number != 0". A follow-up to r1431017 and r1431040.
>
> The commit is good and so is the comment on replay.c, but this should
> read "number ? TRUE : FALSE" to be correct and match the code.
Oops. I've edited the log. Thanks.
- Julian