You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@hive.apache.org by Jason Dere <jd...@hortonworks.com> on 2013/11/16 04:29:30 UTC
Review Request 15607: HIVE-5825 Case statement type checking too restrictive
for parameterized types
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/15607/
-----------------------------------------------------------
Review request for hive and Xuefu Zhang.
Bugs: HIVE-5825
https://issues.apache.org/jira/browse/HIVE-5825
Repository: hive-git
Description
-------
Allow type conversions to common type for case/when statements.
Diffs
-----
ql/src/java/org/apache/hadoop/hive/ql/udf/generic/GenericUDFCase.java 49ec215
ql/src/java/org/apache/hadoop/hive/ql/udf/generic/GenericUDFWhen.java 554af2c
ql/src/test/queries/clientnegative/udf_case_type_wrong.q 2fb5ff7
ql/src/test/queries/clientnegative/udf_case_type_wrong2.q 5772dc1
ql/src/test/queries/clientnegative/udf_case_type_wrong3.q 5aaf018
ql/src/test/queries/clientnegative/udf_when_type_wrong2.q 79fa65f
ql/src/test/queries/clientnegative/udf_when_type_wrong3.q 8bb5fdd
ql/src/test/queries/clientpositive/udf_case.q 03f9f9f
ql/src/test/queries/clientpositive/udf_when.q ec8c42e
ql/src/test/results/clientnegative/udf_case_type_wrong.q.out 3314002
ql/src/test/results/clientnegative/udf_case_type_wrong2.q.out 5be7d66
ql/src/test/results/clientnegative/udf_case_type_wrong3.q.out 901d9a9
ql/src/test/results/clientnegative/udf_when_type_wrong2.q.out e94e6e3
ql/src/test/results/clientnegative/udf_when_type_wrong3.q.out 7d4c12f
ql/src/test/results/clientpositive/udf_case.q.out 4a59a8c
ql/src/test/results/clientpositive/udf_when.q.out 367f48a
Diff: https://reviews.apache.org/r/15607/diff/
Testing
-------
Thanks,
Jason Dere
Re: Review Request 15607: HIVE-5825 Case statement type checking too
restrictive for parameterized types
Posted by Xuefu Zhang <xz...@cloudera.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/15607/#review29006
-----------------------------------------------------------
Ship it!
Ship It!
- Xuefu Zhang
On Nov. 16, 2013, 3:29 a.m., Jason Dere wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/15607/
> -----------------------------------------------------------
>
> (Updated Nov. 16, 2013, 3:29 a.m.)
>
>
> Review request for hive and Xuefu Zhang.
>
>
> Bugs: HIVE-5825
> https://issues.apache.org/jira/browse/HIVE-5825
>
>
> Repository: hive-git
>
>
> Description
> -------
>
> Allow type conversions to common type for case/when statements.
>
>
> Diffs
> -----
>
> ql/src/java/org/apache/hadoop/hive/ql/udf/generic/GenericUDFCase.java 49ec215
> ql/src/java/org/apache/hadoop/hive/ql/udf/generic/GenericUDFWhen.java 554af2c
> ql/src/test/queries/clientnegative/udf_case_type_wrong.q 2fb5ff7
> ql/src/test/queries/clientnegative/udf_case_type_wrong2.q 5772dc1
> ql/src/test/queries/clientnegative/udf_case_type_wrong3.q 5aaf018
> ql/src/test/queries/clientnegative/udf_when_type_wrong2.q 79fa65f
> ql/src/test/queries/clientnegative/udf_when_type_wrong3.q 8bb5fdd
> ql/src/test/queries/clientpositive/udf_case.q 03f9f9f
> ql/src/test/queries/clientpositive/udf_when.q ec8c42e
> ql/src/test/results/clientnegative/udf_case_type_wrong.q.out 3314002
> ql/src/test/results/clientnegative/udf_case_type_wrong2.q.out 5be7d66
> ql/src/test/results/clientnegative/udf_case_type_wrong3.q.out 901d9a9
> ql/src/test/results/clientnegative/udf_when_type_wrong2.q.out e94e6e3
> ql/src/test/results/clientnegative/udf_when_type_wrong3.q.out 7d4c12f
> ql/src/test/results/clientpositive/udf_case.q.out 4a59a8c
> ql/src/test/results/clientpositive/udf_when.q.out 367f48a
>
> Diff: https://reviews.apache.org/r/15607/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Jason Dere
>
>