You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@impala.apache.org by wz...@apache.org on 2023/06/29 05:36:38 UTC

[impala] 02/03: IMPALA-12249: Fix the unexpected word wrap of 'Progress' in WebUI queries page

This is an automated email from the ASF dual-hosted git repository.

wzhou pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/impala.git

commit 96ed92ea75368966794edaa6c361d9d08b0fb3cc
Author: Eyizoha <ey...@163.com>
AuthorDate: Wed Jun 28 11:40:40 2023 +0800

    IMPALA-12249: Fix the unexpected word wrap of 'Progress' in WebUI queries page
    
    This commit replaces the whitespace in 'Scan Progress' and 'Query
    Progress' of queries page with non-breaking spaces (nbsp). This is to
    prevent these headers from breaking at the space when displayed in the
    browser. With this change, the headers will stay on the same line,
    improving the readability of the table headers.
    
    Change-Id: I894ada826282d33c3f2395231db1ddf97bc82367
    Reviewed-on: http://gerrit.cloudera.org:8080/20130
    Reviewed-by: Impala Public Jenkins <im...@cloudera.com>
    Tested-by: Impala Public Jenkins <im...@cloudera.com>
---
 www/queries.tmpl | 13 +++++++------
 1 file changed, 7 insertions(+), 6 deletions(-)

diff --git a/www/queries.tmpl b/www/queries.tmpl
index 0eba10ebb..95a763a2f 100644
--- a/www/queries.tmpl
+++ b/www/queries.tmpl
@@ -37,6 +37,7 @@ command line parameter.</p>
     <th>
       <span title="{{tips_duration}}">Duration</span>
       <hr style="margin-top:0px;margin-bottom:0px;"/>
+      <!-- Using &nbsp; instead of ' ' prevents line breaks in the table header. -->
       <span title="{{tips_queued_duration}}">Queued&nbsp;Duration</span>
     </th>
     <th>
@@ -45,9 +46,9 @@ command line parameter.</p>
       <span title="{{tips_mem_estimate}}">Mem&nbsp;Estimate</span>
     </th>
     <th>
-      <span title="{{tips_scan_progress}}">Scan Progress</span>
+      <span title="{{tips_scan_progress}}">Scan&nbsp;Progress</span>
       <hr style="margin-top:0px;margin-bottom:0px;"/>
-      <span title="{{tips_query_progress}}">Query Progress</span>
+      <span title="{{tips_query_progress}}">Query&nbsp;Progress</span>
     </th>
     <th>
       <span title="{{tips_bytes_read}}">Bytes&nbsp;Read</span>
@@ -109,9 +110,9 @@ command line parameter.</p>
       <span title="{{tips_mem_estimate}}">Mem&nbsp;Estimate</span>
     </th>
     <th>
-      <span title="{{tips_scan_progress}}">Scan Progress</span>
+      <span title="{{tips_scan_progress}}">Scan&nbsp;Progress</span>
       <hr style="margin-top:0px;margin-bottom:0px;"/>
-      <span title="{{tips_query_progress}}">Query Progress</span>
+      <span title="{{tips_query_progress}}">Query&nbsp;Progress</span>
     </th>
     <th>
       <span title="{{tips_bytes_read}}">Bytes&nbsp;Read</span>
@@ -170,9 +171,9 @@ command line parameter.</p>
       <span title="{{tips_mem_estimate}}">Mem&nbsp;Estimate</span>
     </th>
     <th>
-      <span title="{{tips_scan_progress}}">Scan Progress</span>
+      <span title="{{tips_scan_progress}}">Scan&nbsp;Progress</span>
       <hr style="margin-top:0px;margin-bottom:0px;"/>
-      <span title="{{tips_query_progress}}">Query Progress</span>
+      <span title="{{tips_query_progress}}">Query&nbsp;Progress</span>
     </th>
     <th>
       <span title="{{tips_bytes_read}}">Bytes&nbsp;Read</span>