[GitHub] GabeLoins commented on a change in pull request #4991: [Bugfix] Allowing sqlExpression to be blank

[GitBox <gi...@apache.org>]

GabeLoins commented on a change in pull request #4991: [Bugfix] Allowing sqlExpression to be blank
URL: https://github.com/apache/incubator-superset/pull/4991#discussion_r187750167
 
 

 ##########
 File path: superset/assets/src/explore/AdhocFilter.js
 ##########
 @@ -45,7 +45,8 @@ export default class AdhocFilter {
       this.clause = adhocFilter.clause;
       this.sqlExpression = null;
 
 Review comment:
   sqlExpression can be set to null here, so you can't predict whether it will be `undefined` or `null`

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org