You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@rave.apache.org by Aaron Gooch <eo...@gmail.com> on 2012/12/03 14:30:15 UTC
Review Request: RAVE-848 bug fix
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/8317/
-----------------------------------------------------------
Review request for rave.
Description
-------
This is a small change to the person controller. I have added the proper response code of 404 for user not found and added a logging statement in the event there was an unexpected exception thrown (I believe the expectation was the user was null).
This addresses bug RAVE-848.
https://issues.apache.org/jira/browse/RAVE-848
Diffs
-----
Diff: https://reviews.apache.org/r/8317/diff/
Testing
-------
Thanks,
Aaron Gooch
Re: Review Request: RAVE-848 bug fix
Posted by Matt Franklin <mf...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/8317/#review14102
-----------------------------------------------------------
trunk/rave-components/rave-web/src/main/java/org/apache/rave/portal/web/controller/ProfileController.java
<https://reviews.apache.org/r/8317/#comment30173>
Not critical, but it would probably be best to throw a not found exception and use spring's exeception view resolver to return the desired page
trunk/rave-components/rave-web/src/main/java/org/apache/rave/portal/web/controller/ProfileController.java
<https://reviews.apache.org/r/8317/#comment30174>
duplicated code. separate into helper method
- Matt Franklin
On Dec. 6, 2012, 3:14 p.m., Aaron Gooch wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/8317/
> -----------------------------------------------------------
>
> (Updated Dec. 6, 2012, 3:14 p.m.)
>
>
> Review request for rave.
>
>
> Description
> -------
>
> This is a small change to the person controller. I have added the proper response code of 404 for user not found and added a logging statement in the event there was an unexpected exception thrown (I believe the expectation was the user was null).
>
>
> This addresses bug RAVE-848.
> https://issues.apache.org/jira/browse/RAVE-848
>
>
> Diffs
> -----
>
> trunk/rave-components/rave-web/src/main/java/org/apache/rave/portal/web/controller/ProfileController.java 1415304
> trunk/rave-components/rave-web/src/test/java/org/apache/rave/portal/web/controller/ProfileControllerTest.java 1415304
>
> Diff: https://reviews.apache.org/r/8317/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Aaron Gooch
>
>
Re: Review Request: RAVE-848 bug fix
Posted by Matt Franklin <mf...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/8317/#review14349
-----------------------------------------------------------
Ship it!
Applied r1420533
- Matt Franklin
On Dec. 11, 2012, 4:21 p.m., Aaron Gooch wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/8317/
> -----------------------------------------------------------
>
> (Updated Dec. 11, 2012, 4:21 p.m.)
>
>
> Review request for rave.
>
>
> Description
> -------
>
> This is a small change to the person controller. I have added the proper response code of 404 for user not found and added a logging statement in the event there was an unexpected exception thrown (I believe the expectation was the user was null).
>
>
> This addresses bug RAVE-848.
> https://issues.apache.org/jira/browse/RAVE-848
>
>
> Diffs
> -----
>
> trunk/rave-components/rave-web/src/main/java/org/apache/rave/portal/web/controller/ProfileController.java 1420238
> trunk/rave-components/rave-web/src/test/java/org/apache/rave/portal/web/controller/ProfileControllerTest.java 1420238
>
> Diff: https://reviews.apache.org/r/8317/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Aaron Gooch
>
>
Re: Review Request: RAVE-848 bug fix
Posted by Aaron Gooch <eo...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/8317/
-----------------------------------------------------------
(Updated Dec. 11, 2012, 4:21 p.m.)
Review request for rave.
Changes
-------
updated patch file - did not implement spring view resolvers. Doing so seems to be a larger task than handling these error cases. We should update the entire application to use the HandlerExceptionResolver.
Description
-------
This is a small change to the person controller. I have added the proper response code of 404 for user not found and added a logging statement in the event there was an unexpected exception thrown (I believe the expectation was the user was null).
This addresses bug RAVE-848.
https://issues.apache.org/jira/browse/RAVE-848
Diffs (updated)
-----
trunk/rave-components/rave-web/src/main/java/org/apache/rave/portal/web/controller/ProfileController.java 1420238
trunk/rave-components/rave-web/src/test/java/org/apache/rave/portal/web/controller/ProfileControllerTest.java 1420238
Diff: https://reviews.apache.org/r/8317/diff/
Testing
-------
Thanks,
Aaron Gooch
Re: Review Request: RAVE-848 bug fix
Posted by Aaron Gooch <eo...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/8317/
-----------------------------------------------------------
(Updated Dec. 6, 2012, 3:14 p.m.)
Review request for rave.
Changes
-------
attached patch file
Description
-------
This is a small change to the person controller. I have added the proper response code of 404 for user not found and added a logging statement in the event there was an unexpected exception thrown (I believe the expectation was the user was null).
This addresses bug RAVE-848.
https://issues.apache.org/jira/browse/RAVE-848
Diffs (updated)
-----
trunk/rave-components/rave-web/src/main/java/org/apache/rave/portal/web/controller/ProfileController.java 1415304
trunk/rave-components/rave-web/src/test/java/org/apache/rave/portal/web/controller/ProfileControllerTest.java 1415304
Diff: https://reviews.apache.org/r/8317/diff/
Testing
-------
Thanks,
Aaron Gooch
Re: Review Request: RAVE-848 bug fix
Posted by Aaron Gooch <eo...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/8317/
-----------------------------------------------------------
(Updated Dec. 5, 2012, 2:39 p.m.)
Review request for rave.
Changes
-------
Added missing patch file
Description
-------
This is a small change to the person controller. I have added the proper response code of 404 for user not found and added a logging statement in the event there was an unexpected exception thrown (I believe the expectation was the user was null).
This addresses bug RAVE-848.
https://issues.apache.org/jira/browse/RAVE-848
Diffs
-----
Diff: https://reviews.apache.org/r/8317/diff/
Testing
-------
Thanks,
Aaron Gooch
Re: Review Request: RAVE-848 bug fix
Posted by Aaron Gooch <eo...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/8317/
-----------------------------------------------------------
(Updated Dec. 5, 2012, 2:38 p.m.)
Review request for rave.
Description
-------
This is a small change to the person controller. I have added the proper response code of 404 for user not found and added a logging statement in the event there was an unexpected exception thrown (I believe the expectation was the user was null).
This addresses bug RAVE-848.
https://issues.apache.org/jira/browse/RAVE-848
Diffs
-----
Diff: https://reviews.apache.org/r/8317/diff/
Testing
-------
Thanks,
Aaron Gooch
Re: Review Request: RAVE-848 bug fix
Posted by Matt Franklin <mf...@apache.org>.
> On Dec. 5, 2012, 2:09 p.m., Matt Franklin wrote:
> > I don't see a patch file for this. Did you publish it?
Something is still not right. I can't see/comment on the diff.
- Matt
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/8317/#review14049
-----------------------------------------------------------
On Dec. 5, 2012, 2:39 p.m., Aaron Gooch wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/8317/
> -----------------------------------------------------------
>
> (Updated Dec. 5, 2012, 2:39 p.m.)
>
>
> Review request for rave.
>
>
> Description
> -------
>
> This is a small change to the person controller. I have added the proper response code of 404 for user not found and added a logging statement in the event there was an unexpected exception thrown (I believe the expectation was the user was null).
>
>
> This addresses bug RAVE-848.
> https://issues.apache.org/jira/browse/RAVE-848
>
>
> Diffs
> -----
>
>
> Diff: https://reviews.apache.org/r/8317/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Aaron Gooch
>
>
Re: Review Request: RAVE-848 bug fix
Posted by Matt Franklin <mf...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/8317/#review14049
-----------------------------------------------------------
I don't see a patch file for this. Did you publish it?
- Matt Franklin
On Dec. 3, 2012, 1:30 p.m., Aaron Gooch wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/8317/
> -----------------------------------------------------------
>
> (Updated Dec. 3, 2012, 1:30 p.m.)
>
>
> Review request for rave.
>
>
> Description
> -------
>
> This is a small change to the person controller. I have added the proper response code of 404 for user not found and added a logging statement in the event there was an unexpected exception thrown (I believe the expectation was the user was null).
>
>
> This addresses bug RAVE-848.
> https://issues.apache.org/jira/browse/RAVE-848
>
>
> Diffs
> -----
>
>
> Diff: https://reviews.apache.org/r/8317/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Aaron Gooch
>
>