You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@tajo.apache.org by jinossy <gi...@git.apache.org> on 2015/08/19 16:41:08 UTC
[GitHub] tajo pull request: TAJO-1783: Query result is not returned by inva...
GitHub user jinossy opened a pull request:
https://github.com/apache/tajo/pull/701
TAJO-1783: Query result is not returned by invalid output path
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/jinossy/tajo TAJO-1783
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/tajo/pull/701.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #701
----
commit aecace6ffab6de0604070740df1064aa0814c52a
Author: Jinho Kim <jh...@apache.org>
Date: 2015-08-19T14:39:00Z
TAJO-1783: Query result is not returned by invalid output path.
commit cd1dfddae6a1336cf145f6e51faeafc786823ec9
Author: Jinho Kim <jh...@apache.org>
Date: 2015-08-19T14:39:46Z
Merge branch 'master' of https://git-wip-us.apache.org/repos/asf/tajo into TAJO-1783
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] tajo pull request: TAJO-1783: Query result is not returned by inva...
Posted by jinossy <gi...@git.apache.org>.
Github user jinossy commented on the pull request:
https://github.com/apache/tajo/pull/701#issuecomment-133257810
You can find it like testColumnPartitionedTableByThreeColumns in TestTablePartitions.
https://github.com/apache/tajo/pull/431 does not allow the managed table. so it does not test the non-forwarded query.
Anyway, I’m going to add TestSimpleQuery
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] tajo pull request: TAJO-1783: Query result is not returned by inva...
Posted by hyunsik <gi...@git.apache.org>.
Github user hyunsik commented on the pull request:
https://github.com/apache/tajo/pull/701#issuecomment-133008762
I just reviewed the patch. The change and its clean up look great to me.
I tried to find non-forwarded tests on partitioned tables. I haven't found them. If they exist, could you let me know where they are?
Actually, it's not your problem. But, I'd like to ensure that your change guarantees that non-forwarded scans work well on partitioned tables.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] tajo pull request: TAJO-1783: Query result is not returned by inva...
Posted by hyunsik <gi...@git.apache.org>.
Github user hyunsik commented on the pull request:
https://github.com/apache/tajo/pull/701#issuecomment-133410328
+1
The patch looks great to me. The patch seems to include unit tests to verify the things you changed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] tajo pull request: TAJO-1783: Query result is not returned by inva...
Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:
https://github.com/apache/tajo/pull/701
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---