You are viewing a plain text version of this content. The canonical link for it is here.

Posted to github@arrow.apache.org by GitBox <gi...@apache.org> on 2020/12/10 13:58:43 UTC

[GitHub] [arrow] alamb commented on a change in pull request #8888: ARROW-10865: [Rust] Easier to use Schema -> DFSchema conversion

alamb commented on a change in pull request #8888:
URL: https://github.com/apache/arrow/pull/8888#discussion_r540189450



##########
File path: rust/datafusion/src/logical_plan/dfschema.rs
##########
@@ -89,11 +89,11 @@ impl DFSchema {
     }
 
     /// Create a `DFSchema` from an Arrow schema
-    pub fn from(schema: &Schema) -> Result<Self> {
+    pub fn try_from(schema: Schema) -> Result<Self> {

Review comment:
       renamed this `try_from` to be more consistent with Rust conventions of conversions that can fail




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org