[GitHub] [apisix] membphis commented on a change in pull request #2859: fix: authz keycloak should run in access phase

[GitBox <gi...@apache.org>]

membphis commented on a change in pull request #2859:
URL: https://github.com/apache/apisix/pull/2859#discussion_r532518453



##########
File path: apisix/plugins/basic-auth.lua
##########
@@ -125,7 +125,7 @@ do
     end
 end
 
-function _M.access(conf, ctx)
+function _M.rewrite(conf, ctx)

Review comment:
       why do we need to change another plugin?
   
   one PR for one thing, we should only update something about plugin `authz-keycloak`
   
   please revert this code

##########
File path: apisix/plugins/openid-connect.lua
##########
@@ -49,6 +49,7 @@ local schema = {
 local _M = {
     version = 0.1,
     priority = 2599,
+    type = 'auth',

Review comment:
       ditto
   
   you can create a new PR to fix this




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org