You are viewing a plain text version of this content. The canonical link for it is here.

Posted to reviews@spark.apache.org by "jshmchenxi (via GitHub)" <gi...@apache.org> on 2024/09/02 02:48:45 UTC

Re: [PR] [SPARK-49480][CORE] Fix NullPointerException from `SparkThrowableHelper.isInternalError` [spark]

jshmchenxi commented on PR #47946:
URL: https://github.com/apache/spark/pull/47946#issuecomment-2323702153

   > After your changes, this check `st.getErrorClass != null` is redundant.
   > 
   > https://github.com/apache/spark/blob/c58148da5496245403b55c3fc423d35f3a669c79/core/src/main/scala/org/apache/spark/scheduler/DAGScheduler.scala#L2883
   > 
   > @jshmchenxi Could your remove it, please.
   
   @MaxGekk Removing it will change the condition from false to true when `st.getErrorClass` is null, which doesn't seem to be right.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org