You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@netbeans.apache.org by GitBox <gi...@apache.org> on 2021/12/13 13:15:47 UTC

[GitHub] [netbeans] dbalek opened a new pull request #3367: LSP: Provide completion for SQL queries for repository annotations.

dbalek opened a new pull request #3367:
URL: https://github.com/apache/netbeans/pull/3367


   Completion for SQL queries for repository annotations should be available via LSP.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org

For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists


[GitHub] [netbeans] dbalek merged pull request #3367: LSP: Provide completion for SQL queries for repository annotations.

Posted by GitBox <gi...@apache.org>.
dbalek merged pull request #3367:
URL: https://github.com/apache/netbeans/pull/3367


   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org

For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists


[GitHub] [netbeans] JaroslavTulach commented on a change in pull request #3367: LSP: Provide completion for SQL queries for repository annotations.

Posted by GitBox <gi...@apache.org>.
JaroslavTulach commented on a change in pull request #3367:
URL: https://github.com/apache/netbeans/pull/3367#discussion_r768368737



##########
File path: java/j2ee.persistence/nbproject/project.xml
##########
@@ -52,6 +52,15 @@
                         <specification-version>1.0</specification-version>
                     </run-dependency>
                 </dependency>
+                <dependency>
+                    <code-name-base>org.netbeans.api.lsp</code-name-base>

Review comment:
       Adding such lightweight dependency is OK.

##########
File path: java/java.lsp.server/nbcode/nbproject/platform.properties
##########
@@ -325,12 +311,10 @@ disabled.modules=\
     org.netbeans.modules.xml.catalog.ui,\
     org.netbeans.modules.xml.jaxb,\
     org.netbeans.modules.xml.jaxb.api,\
-    org.netbeans.modules.xml.multiview,\

Review comment:
       A bit too many new dependencies. Could some of them be eliminated by restructuring the modules? I am sure you don't really need `xml.multiview` in VSCode. Why do we need `schema2beans`? `eclipselink`?
   
   I understand that currently the needed modules (`*.persistance`?) have such dependencies. What it would take to eliminate some of them?




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org

For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists


[GitHub] [netbeans] sdedic commented on a change in pull request #3367: LSP: Provide completion for SQL queries for repository annotations.

Posted by GitBox <gi...@apache.org>.
sdedic commented on a change in pull request #3367:
URL: https://github.com/apache/netbeans/pull/3367#discussion_r768467449



##########
File path: java/java.lsp.server/nbcode/nbproject/platform.properties
##########
@@ -325,12 +311,10 @@ disabled.modules=\
     org.netbeans.modules.xml.catalog.ui,\
     org.netbeans.modules.xml.jaxb,\
     org.netbeans.modules.xml.jaxb.api,\
-    org.netbeans.modules.xml.multiview,\

Review comment:
       I filed [NETBEANS-6295](https://issues.apache.org/jira/browse/NETBEANS-6295) ... the LSP is getting bloated. We should also invent a way how the project- db- etc supports can plug into the basic LSP protocol server so that we don't increase the dependency nexus. So filed also [NETBEANS-6296](https://issues.apache.org/jira/browse/NETBEANS-6296)




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org

For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists


[GitHub] [netbeans] dbalek commented on a change in pull request #3367: LSP: Provide completion for SQL queries for repository annotations.

Posted by GitBox <gi...@apache.org>.
dbalek commented on a change in pull request #3367:
URL: https://github.com/apache/netbeans/pull/3367#discussion_r768437547



##########
File path: java/java.lsp.server/nbcode/nbproject/platform.properties
##########
@@ -325,12 +311,10 @@ disabled.modules=\
     org.netbeans.modules.xml.catalog.ui,\
     org.netbeans.modules.xml.jaxb,\
     org.netbeans.modules.xml.jaxb.api,\
-    org.netbeans.modules.xml.multiview,\

Review comment:
       The problem is that the `j2ee.persistence` module is huge and its split into  `j2ee.persistence.base` and  `j2ee.persistence` would require a substantial amount of time. We should IMHO plan some NBLS module cleanup for the next release.




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org

For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists