You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@netbeans.apache.org by GitBox <gi...@apache.org> on 2021/07/14 10:57:47 UTC

[GitHub] [netbeans] junichi11 opened a new pull request #3052: [NETBEANS-5678] Use the URL of the forked repository of the Skeleton Generator

junichi11 opened a new pull request #3052:
URL: https://github.com/apache/netbeans/pull/3052


   https://issues.apache.org/jira/browse/NETBEANS-5678
   
   - The original PHPUnit skeleton generator has been abandoned
   
   The forked repo: https://github.com/VitexSoftware/phpunit-skeleton-generator
   
   ![netbeans-5678-phpunit-options](https://user-images.githubusercontent.com/738383/125610703-f40dab9d-11a9-4fa6-bd18-86947553eee2.png)
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org

For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists

[GitHub] [netbeans] tmysik commented on a change in pull request #3052: [NETBEANS-5678] Use the URL of the forked repository of the Skeleton Generator

Posted by GitBox <gi...@apache.org>.
tmysik commented on a change in pull request #3052:
URL: https://github.com/apache/netbeans/pull/3052#discussion_r669595608



##########
File path: php/php.phpunit/src/org/netbeans/modules/php/phpunit/ui/options/Bundle.properties
##########
@@ -59,6 +59,7 @@ PhpUnitOptionsPanel.phpUnitInfoLabel.AccessibleContext.accessibleName=PHPUnit cl
 PhpUnitOptionsPanel.noteLabel.AccessibleContext.accessibleName=Note:
 PhpUnitOptionsPanel.skelGenLabel.text=&Skeleton Generator Script:
 PhpUnitOptionsPanel.phpUnitLearnMoreLabel.text=<html><a href="#">Learn more about PHPUnit</a></html>
-PhpUnitOptionsPanel.skelGenLearnMoreLabel.text=<html><a href="#">Learn more about Skeleton Generator</a></html>
+PhpUnitOptionsPanel.skelGenLearnMoreLabel.text=<html><a href="#">Learn more about Skeleton Generator</a> (forked repo.)</html>
 PhpUnitOptionsPanel.skelGenBrowseButton.text=&Browse...
 PhpUnitOptionsPanel.skelGenSearchButton.text=S&earch...
+PhpUnitOptionsPanel.skelGenAbandonedLabel.text=<html><b>The original generator has been abandoned.</b></html>

Review comment:
       Nitpick: perhaps "The original [project]"?
   




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org

For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists

[GitHub] [netbeans] junichi11 commented on pull request #3052: [NETBEANS-5678] Use the URL of the forked repository of the Skeleton Generator

Posted by GitBox <gi...@apache.org>.
junichi11 commented on pull request #3052:
URL: https://github.com/apache/netbeans/pull/3052#issuecomment-879883199


   @tmysik We can merge it :) 


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org

For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists

[GitHub] [netbeans] tmysik commented on pull request #3052: [NETBEANS-5678] Use the URL of the forked repository of the Skeleton Generator

Posted by GitBox <gi...@apache.org>.
tmysik commented on pull request #3052:
URL: https://github.com/apache/netbeans/pull/3052#issuecomment-879874871


   @junichi11 Please, let me know - again, heh - whether this PR can be merged. Thanks!
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org

For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists

[GitHub] [netbeans] junichi11 commented on pull request #3052: [NETBEANS-5678] Use the URL of the forked repository of the Skeleton Generator

Posted by GitBox <gi...@apache.org>.
junichi11 commented on pull request #3052:
URL: https://github.com/apache/netbeans/pull/3052#issuecomment-879943960


   @tmysik OK. Just in case, I added other reviewers. (Maybe, the feature freeze date is tomorrow(7/15).) Thanks!


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org

For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists

[GitHub] [netbeans] junichi11 commented on a change in pull request #3052: [NETBEANS-5678] Use the URL of the forked repository of the Skeleton Generator

Posted by GitBox <gi...@apache.org>.
junichi11 commented on a change in pull request #3052:
URL: https://github.com/apache/netbeans/pull/3052#discussion_r669606655



##########
File path: php/php.phpunit/src/org/netbeans/modules/php/phpunit/ui/options/Bundle.properties
##########
@@ -59,6 +59,7 @@ PhpUnitOptionsPanel.phpUnitInfoLabel.AccessibleContext.accessibleName=PHPUnit cl
 PhpUnitOptionsPanel.noteLabel.AccessibleContext.accessibleName=Note:
 PhpUnitOptionsPanel.skelGenLabel.text=&Skeleton Generator Script:
 PhpUnitOptionsPanel.phpUnitLearnMoreLabel.text=<html><a href="#">Learn more about PHPUnit</a></html>
-PhpUnitOptionsPanel.skelGenLearnMoreLabel.text=<html><a href="#">Learn more about Skeleton Generator</a></html>
+PhpUnitOptionsPanel.skelGenLearnMoreLabel.text=<html><a href="#">Learn more about Skeleton Generator</a> (forked repo.)</html>
 PhpUnitOptionsPanel.skelGenBrowseButton.text=&Browse...
 PhpUnitOptionsPanel.skelGenSearchButton.text=S&earch...
+PhpUnitOptionsPanel.skelGenAbandonedLabel.text=<html><b>The original generator has been abandoned.</b></html>

Review comment:
       Fixed: https://github.com/apache/netbeans/compare/5b834cfeff13ca3279108fa7f0e0cba8448f5d91..2f71bb9cbc2e065360a210d7ef32caa98a0278e9




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org

For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists

[GitHub] [netbeans] tmysik commented on pull request #3052: [NETBEANS-5678] Use the URL of the forked repository of the Skeleton Generator

Posted by GitBox <gi...@apache.org>.
tmysik commented on pull request #3052:
URL: https://github.com/apache/netbeans/pull/3052#issuecomment-879935899


   @junichi11 
   
   Will wait for the other reviewers and merge it later. Thanks!
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org

For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists

[GitHub] [netbeans] tmysik merged pull request #3052: [NETBEANS-5678] Use the URL of the forked repository of the Skeleton Generator

Posted by GitBox <gi...@apache.org>.
tmysik merged pull request #3052:
URL: https://github.com/apache/netbeans/pull/3052


   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org

For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists

[GitHub] [netbeans] junichi11 commented on a change in pull request #3052: [NETBEANS-5678] Use the URL of the forked repository of the Skeleton Generator

Posted by GitBox <gi...@apache.org>.
junichi11 commented on a change in pull request #3052:
URL: https://github.com/apache/netbeans/pull/3052#discussion_r669600728



##########
File path: php/php.phpunit/src/org/netbeans/modules/php/phpunit/ui/options/Bundle.properties
##########
@@ -59,6 +59,7 @@ PhpUnitOptionsPanel.phpUnitInfoLabel.AccessibleContext.accessibleName=PHPUnit cl
 PhpUnitOptionsPanel.noteLabel.AccessibleContext.accessibleName=Note:
 PhpUnitOptionsPanel.skelGenLabel.text=&Skeleton Generator Script:
 PhpUnitOptionsPanel.phpUnitLearnMoreLabel.text=<html><a href="#">Learn more about PHPUnit</a></html>
-PhpUnitOptionsPanel.skelGenLearnMoreLabel.text=<html><a href="#">Learn more about Skeleton Generator</a></html>
+PhpUnitOptionsPanel.skelGenLearnMoreLabel.text=<html><a href="#">Learn more about Skeleton Generator</a> (forked repo.)</html>
 PhpUnitOptionsPanel.skelGenBrowseButton.text=&Browse...
 PhpUnitOptionsPanel.skelGenSearchButton.text=S&earch...
+PhpUnitOptionsPanel.skelGenAbandonedLabel.text=<html><b>The original generator has been abandoned.</b></html>

Review comment:
       Will fix ("The original project has been abandoned."). Thanks!




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org

For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists

[GitHub] [netbeans] tmysik commented on pull request #3052: [NETBEANS-5678] Use the URL of the forked repository of the Skeleton Generator

Posted by GitBox <gi...@apache.org>.
tmysik commented on pull request #3052:
URL: https://github.com/apache/netbeans/pull/3052#issuecomment-880437375


   Not a big change, merging.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org

For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists