[GitHub] [druid] kaijianding commented on a change in pull request #10688: Historical lazy on start enhancement with segment files check

[GitBox <gi...@apache.org>]

kaijianding commented on a change in pull request #10688:
URL: https://github.com/apache/druid/pull/10688#discussion_r552395540



##########
File path: processing/src/main/java/org/apache/druid/segment/IndexIO.java
##########
@@ -182,16 +183,16 @@ public void validateTwoSegments(final IndexableAdapter adapter1, final Indexable
 
   public QueryableIndex loadIndex(File inDir) throws IOException
   {
-    return loadIndex(inDir, false);
+    return loadIndex(inDir, false, CommonCallback.NOOP);
   }

Review comment:
       add blank line here

##########
File path: core/src/main/java/org/apache/druid/coordination/CommonCallback.java
##########
@@ -0,0 +1,26 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements.  See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership.  The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License.  You may obtain a copy of the License at
+ *
+ *   http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing,
+ * software distributed under the License is distributed on an
+ * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+ * KIND, either express or implied.  See the License for the
+ * specific language governing permissions and limitations
+ * under the License.
+ */
+
+package org.apache.druid.coordination;
+
+public interface CommonCallback

Review comment:
       Use a more meaningful name, like SegmentLazyLoadFailCallback

##########
File path: processing/src/main/java/org/apache/druid/segment/IndexIO.java
##########
@@ -644,7 +649,7 @@ public QueryableIndex load(File inDir, ObjectMapper mapper, boolean lazy) throws
     }
 
     private ColumnHolder deserializeColumn(ObjectMapper mapper, ByteBuffer byteBuffer, SmooshedFileMapper smooshedFiles)
-        throws IOException
+        throws IOException, RuntimeException

Review comment:
       why RuntimeException here?




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@druid.apache.org
For additional commands, e-mail: commits-help@druid.apache.org