You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@flink.apache.org by GitBox <gi...@apache.org> on 2020/08/05 02:01:56 UTC
[GitHub] [flink] shuiqiangchen opened a new pull request #13061: [FLINK-18764][python] Add DataStream class and support from_collectio…
shuiqiangchen opened a new pull request #13061:
URL: https://github.com/apache/flink/pull/13061
<!--
*Thank you very much for contributing to Apache Flink - we are happy that you want to help us improve Flink. To help the community review your contribution in the best possible way, please go through the checklist below, which will get the contribution into a shape in which it can be best reviewed.*
*Please understand that we do not do this to make contributions to Flink a hassle. In order to uphold a high standard of quality for code contributions, while at the same time managing a large number of contributions, we need contributors to prepare the contributions well, and give reviewers enough contextual information for the review. Please also understand that contributions that do not follow this guide will take longer to review and thus typically be picked up with lower priority by the community.*
## Contribution Checklist
- Make sure that the pull request corresponds to a [JIRA issue](https://issues.apache.org/jira/projects/FLINK/issues). Exceptions are made for typos in JavaDoc or documentation files, which need no JIRA issue.
- Name the pull request in the form "[FLINK-XXXX] [component] Title of the pull request", where *FLINK-XXXX* should be replaced by the actual issue number. Skip *component* if you are unsure about which is the best component.
Typo fixes that have no associated JIRA issue should be named following this pattern: `[hotfix] [docs] Fix typo in event time introduction` or `[hotfix] [javadocs] Expand JavaDoc for PuncuatedWatermarkGenerator`.
- Fill out the template below to describe the changes contributed by the pull request. That will give reviewers the context they need to do the review.
- Make sure that the change passes the automated tests, i.e., `mvn clean verify` passes. You can set up Azure Pipelines CI to do that following [this guide](https://cwiki.apache.org/confluence/display/FLINK/Azure+Pipelines#AzurePipelines-Tutorial:SettingupAzurePipelinesforaforkoftheFlinkrepository).
- Each pull request should address only one issue, not mix up code from multiple issues.
- Each commit in the pull request has a meaningful commit message (including the JIRA id)
- Once all items of the checklist are addressed, remove the above text and this checklist, leaving only the filled out template below.
**(The sections below can be removed for hotfixes of typos)**
-->
## What is the purpose of the change
Introduced a new class named DataStream including its common interfaces. And support to get a DataStream through StreamExecutionEnvironment.from_collection().
## Brief change log
- add a new python module named DataStream.
- support to get a DataStream through StreamExecutionEnvironment.from_collection()
## Verifying this change
This change is verified by the test cases in test_stream_execution_environment.py
## Does this pull request potentially affect one of the following parts:
- Dependencies (does it add or upgrade a dependency): ( no)
- The public API, i.e., is any changed class annotated with `@Public(Evolving)`: (no)
- The serializers: (no)
- The runtime per-record code paths (performance sensitive): (no)
- Anything that affects deployment or recovery: JobManager (and its components), Checkpointing, Kubernetes/Yarn/Mesos, ZooKeeper: (no)
- The S3 file system connector: (no)
## Documentation
- Does this pull request introduce a new feature? (yes)
- If yes, how is the feature documented? ( not documented)
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #13061: [FLINK-18764][python] Add DataStream class and support from_collectio…
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #13061:
URL: https://github.com/apache/flink/pull/13061#issuecomment-668934853
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "8ccc4bad17d568058446ad6816a6d181f090ecf0",
"status" : "PENDING",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=5180",
"triggerID" : "8ccc4bad17d568058446ad6816a6d181f090ecf0",
"triggerType" : "PUSH"
}, {
"hash" : "368d8222d19ce27d3867747cad727def0ae35da1",
"status" : "PENDING",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=5186",
"triggerID" : "368d8222d19ce27d3867747cad727def0ae35da1",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 8ccc4bad17d568058446ad6816a6d181f090ecf0 Azure: [PENDING](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=5180)
* 368d8222d19ce27d3867747cad727def0ae35da1 Azure: [PENDING](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=5186)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot commented on pull request #13061: [FLINK-18764][python] Add DataStream class and support from_collectio…
Posted by GitBox <gi...@apache.org>.
flinkbot commented on pull request #13061:
URL: https://github.com/apache/flink/pull/13061#issuecomment-668934853
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "8ccc4bad17d568058446ad6816a6d181f090ecf0",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "8ccc4bad17d568058446ad6816a6d181f090ecf0",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 8ccc4bad17d568058446ad6816a6d181f090ecf0 UNKNOWN
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #13061: [FLINK-18764][python] Add DataStream class and support from_collectio…
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #13061:
URL: https://github.com/apache/flink/pull/13061#issuecomment-668934853
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "8ccc4bad17d568058446ad6816a6d181f090ecf0",
"status" : "SUCCESS",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=5180",
"triggerID" : "8ccc4bad17d568058446ad6816a6d181f090ecf0",
"triggerType" : "PUSH"
}, {
"hash" : "368d8222d19ce27d3867747cad727def0ae35da1",
"status" : "PENDING",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=5186",
"triggerID" : "368d8222d19ce27d3867747cad727def0ae35da1",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 8ccc4bad17d568058446ad6816a6d181f090ecf0 Azure: [SUCCESS](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=5180)
* 368d8222d19ce27d3867747cad727def0ae35da1 Azure: [PENDING](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=5186)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] hequn8128 merged pull request #13061: [FLINK-18764][python] Add DataStream class and support from_collectio…
Posted by GitBox <gi...@apache.org>.
hequn8128 merged pull request #13061:
URL: https://github.com/apache/flink/pull/13061
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] shuiqiangchen commented on a change in pull request #13061: [FLINK-18764][python] Add DataStream class and support from_collectio…
Posted by GitBox <gi...@apache.org>.
shuiqiangchen commented on a change in pull request #13061:
URL: https://github.com/apache/flink/pull/13061#discussion_r465444604
##########
File path: flink-python/pyflink/datastream/tests/test_stream_execution_environment.py
##########
@@ -22,9 +22,12 @@
import unittest
+
Review comment:
Thank you, I will pay more attention to it.
##########
File path: flink-python/pyflink/datastream/tests/test_stream_execution_environment.py
##########
@@ -211,3 +214,31 @@ def test_execute(self):
self.assertEqual(len(execution_result.get_all_accumulator_results()), 0)
self.assertIsNone(execution_result.get_accumulator_result('accumulator'))
self.assertIsNotNone(str(execution_result))
+
+ def test_from_collection_without_data_types(self):
+ ds = self.env.from_collection([(1, 'Hi', 'Hello'), (2, 'Hello', 'Hi')])
+ test_sink = DataStreamTestCollectSink(True)
+ ds._j_data_stream.addSink(test_sink._j_data_stream_test_collect_sink)
Review comment:
Yes, there might be some spaces for improvements.
##########
File path: flink-python/pyflink/datastream/tests/test_util.py
##########
@@ -0,0 +1,45 @@
+################################################################################
+# Licensed to the Apache Software Foundation (ASF) under one
+# or more contributor license agreements. See the NOTICE file
+# distributed with this work for additional information
+# regarding copyright ownership. The ASF licenses this file
+# to you under the Apache License, Version 2.0 (the
+# "License"); you may not use this file except in compliance
+# with the License. You may obtain a copy of the License at
+#
+# http://www.apache.org/licenses/LICENSE-2.0
+#
+# Unless required by applicable law or agreed to in writing, software
+# distributed under the License is distributed on an "AS IS" BASIS,
+# WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+# See the License for the specific language governing permissions and
+# limitations under the License.
+################################################################################
+
+import pickle
+
+from pyflink.java_gateway import get_gateway
+
+
+class DataStreamTestCollectSink(object):
Review comment:
Ok, I will do it.
##########
File path: flink-python/pyflink/datastream/data_stream.py
##########
@@ -0,0 +1,162 @@
+################################################################################
+# Licensed to the Apache Software Foundation (ASF) under one
+# or more contributor license agreements. See the NOTICE file
+# distributed with this work for additional information
+# regarding copyright ownership. The ASF licenses this file
+# to you under the Apache License, Version 2.0 (the
+# "License"); you may not use this file except in compliance
+# with the License. You may obtain a copy of the License at
+#
+# http://www.apache.org/licenses/LICENSE-2.0
+#
+# Unless required by applicable law or agreed to in writing, software
+# distributed under the License is distributed on an "AS IS" BASIS,
+# WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+# See the License for the specific language governing permissions and
+# limitations under the License.
+################################################################################
+from pyflink.common import typeinfo, ExecutionConfig
+from pyflink.common.typeinfo import TypeInformation
+
+
+class DataStream(object):
+ """
+ A DataStream represents a stream of elements of the same type. A DataStream can be transformed
+ into another DataStream by applying a transformation as for example:
+ ::
+ >>> DataStream.map(MapFunctionImpl())
+ >>> DataStream.filter(FilterFunctionImpl())
+ """
+
+ def __init__(self, j_data_stream):
+ self._j_data_stream = j_data_stream
+
+ def get_name(self) -> str:
+ """
+ Gets the name of the current data stream. This name is used by the visualization and logging
+ during runtime.
+
+ :return: Name of the stream.
+ """
+ return self._j_data_stream.getName()
+
+ def name(self, name: str):
Review comment:
Yes, I will add the corresponding tests to verify them.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] hequn8128 commented on pull request #13061: [FLINK-18764][python] Add DataStream class and support from_collectio…
Posted by GitBox <gi...@apache.org>.
hequn8128 commented on pull request #13061:
URL: https://github.com/apache/flink/pull/13061#issuecomment-669009510
@shuiqiangchen Thanks a lot for the update. LGTM, will merge this pr after test passed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot commented on pull request #13061: [FLINK-18764][python] Add DataStream class and support from_collectio…
Posted by GitBox <gi...@apache.org>.
flinkbot commented on pull request #13061:
URL: https://github.com/apache/flink/pull/13061#issuecomment-668930657
Thanks a lot for your contribution to the Apache Flink project. I'm the @flinkbot. I help the community
to review your pull request. We will use this comment to track the progress of the review.
## Automated Checks
Last check on commit 8ccc4bad17d568058446ad6816a6d181f090ecf0 (Wed Aug 05 02:03:36 UTC 2020)
**Warnings:**
* **1 pom.xml files were touched**: Check for build and licensing issues.
* No documentation files were touched! Remember to keep the Flink docs up to date!
* **This pull request references an unassigned [Jira ticket](https://issues.apache.org/jira/browse/FLINK-18764).** According to the [code contribution guide](https://flink.apache.org/contributing/contribute-code.html), tickets need to be assigned before starting with the implementation work.
<sub>Mention the bot in a comment to re-run the automated checks.</sub>
## Review Progress
* ❓ 1. The [description] looks good.
* ❓ 2. There is [consensus] that the contribution should go into to Flink.
* ❓ 3. Needs [attention] from.
* ❓ 4. The change fits into the overall [architecture].
* ❓ 5. Overall code [quality] is good.
Please see the [Pull Request Review Guide](https://flink.apache.org/contributing/reviewing-prs.html) for a full explanation of the review process.<details>
The Bot is tracking the review progress through labels. Labels are applied according to the order of the review items. For consensus, approval by a Flink committer of PMC member is required <summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot approve description` to approve one or more aspects (aspects: `description`, `consensus`, `architecture` and `quality`)
- `@flinkbot approve all` to approve all aspects
- `@flinkbot approve-until architecture` to approve everything until `architecture`
- `@flinkbot attention @username1 [@username2 ..]` to require somebody's attention
- `@flinkbot disapprove architecture` to remove an approval you gave earlier
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] shuiqiangchen commented on pull request #13061: [FLINK-18764][python] Add DataStream class and support from_collectio…
Posted by GitBox <gi...@apache.org>.
shuiqiangchen commented on pull request #13061:
URL: https://github.com/apache/flink/pull/13061#issuecomment-668982834
Hi @hequn8128 , thank you for your comments, I have updated the pr according to your suggestions, please have a look at it.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #13061: [FLINK-18764][python] Add DataStream class and support from_collectio…
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #13061:
URL: https://github.com/apache/flink/pull/13061#issuecomment-668934853
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "8ccc4bad17d568058446ad6816a6d181f090ecf0",
"status" : "PENDING",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=5180",
"triggerID" : "8ccc4bad17d568058446ad6816a6d181f090ecf0",
"triggerType" : "PUSH"
}, {
"hash" : "368d8222d19ce27d3867747cad727def0ae35da1",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "368d8222d19ce27d3867747cad727def0ae35da1",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 8ccc4bad17d568058446ad6816a6d181f090ecf0 Azure: [PENDING](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=5180)
* 368d8222d19ce27d3867747cad727def0ae35da1 UNKNOWN
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] hequn8128 commented on a change in pull request #13061: [FLINK-18764][python] Add DataStream class and support from_collectio…
Posted by GitBox <gi...@apache.org>.
hequn8128 commented on a change in pull request #13061:
URL: https://github.com/apache/flink/pull/13061#discussion_r465435385
##########
File path: flink-python/pyflink/datastream/tests/test_util.py
##########
@@ -0,0 +1,45 @@
+################################################################################
+# Licensed to the Apache Software Foundation (ASF) under one
+# or more contributor license agreements. See the NOTICE file
+# distributed with this work for additional information
+# regarding copyright ownership. The ASF licenses this file
+# to you under the Apache License, Version 2.0 (the
+# "License"); you may not use this file except in compliance
+# with the License. You may obtain a copy of the License at
+#
+# http://www.apache.org/licenses/LICENSE-2.0
+#
+# Unless required by applicable law or agreed to in writing, software
+# distributed under the License is distributed on an "AS IS" BASIS,
+# WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+# See the License for the specific language governing permissions and
+# limitations under the License.
+################################################################################
+
+import pickle
+
+from pyflink.java_gateway import get_gateway
+
+
+class DataStreamTestCollectSink(object):
Review comment:
Refactor the class according to the comments above.
##########
File path: flink-python/pyflink/datastream/tests/test_stream_execution_environment.py
##########
@@ -22,9 +22,12 @@
import unittest
+
Review comment:
Please be careful about these unnecessary changes.
##########
File path: flink-python/pyflink/datastream/tests/test_stream_execution_environment.py
##########
@@ -211,3 +214,31 @@ def test_execute(self):
self.assertEqual(len(execution_result.get_all_accumulator_results()), 0)
self.assertIsNone(execution_result.get_accumulator_result('accumulator'))
self.assertIsNotNone(str(execution_result))
+
+ def test_from_collection_without_data_types(self):
+ ds = self.env.from_collection([(1, 'Hi', 'Hello'), (2, 'Hello', 'Hi')])
+ test_sink = DataStreamTestCollectSink(True)
+ ds._j_data_stream.addSink(test_sink._j_data_stream_test_collect_sink)
Review comment:
There are some problems with the design:
1. we need to pass java datastream object explicitly which should be avoided.
2. we need to specify True false manually. I think we can infer the true false from the input datastream, i.e., set true when output_type is `PickledBytesTypeInfo`.
The code may looks like:
```
collect_util = DataStreamCollectUtil()
collect_util.collect(ds)
results = collect_util.results()
```
##########
File path: flink-python/pyflink/datastream/data_stream.py
##########
@@ -0,0 +1,162 @@
+################################################################################
+# Licensed to the Apache Software Foundation (ASF) under one
+# or more contributor license agreements. See the NOTICE file
+# distributed with this work for additional information
+# regarding copyright ownership. The ASF licenses this file
+# to you under the Apache License, Version 2.0 (the
+# "License"); you may not use this file except in compliance
+# with the License. You may obtain a copy of the License at
+#
+# http://www.apache.org/licenses/LICENSE-2.0
+#
+# Unless required by applicable law or agreed to in writing, software
+# distributed under the License is distributed on an "AS IS" BASIS,
+# WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+# See the License for the specific language governing permissions and
+# limitations under the License.
+################################################################################
+from pyflink.common import typeinfo, ExecutionConfig
+from pyflink.common.typeinfo import TypeInformation
+
+
+class DataStream(object):
+ """
+ A DataStream represents a stream of elements of the same type. A DataStream can be transformed
+ into another DataStream by applying a transformation as for example:
+ ::
+ >>> DataStream.map(MapFunctionImpl())
+ >>> DataStream.filter(FilterFunctionImpl())
+ """
+
+ def __init__(self, j_data_stream):
+ self._j_data_stream = j_data_stream
+
+ def get_name(self) -> str:
+ """
+ Gets the name of the current data stream. This name is used by the visualization and logging
+ during runtime.
+
+ :return: Name of the stream.
+ """
+ return self._j_data_stream.getName()
+
+ def name(self, name: str):
Review comment:
Should also add tests to verify these methods.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #13061: [FLINK-18764][python] Add DataStream class and support from_collectio…
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #13061:
URL: https://github.com/apache/flink/pull/13061#issuecomment-668934853
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "8ccc4bad17d568058446ad6816a6d181f090ecf0",
"status" : "PENDING",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=5180",
"triggerID" : "8ccc4bad17d568058446ad6816a6d181f090ecf0",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 8ccc4bad17d568058446ad6816a6d181f090ecf0 Azure: [PENDING](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=5180)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org