You are viewing a plain text version of this content. The canonical link for it is here.
Posted to jira@kafka.apache.org by GitBox <gi...@apache.org> on 2020/06/10 22:26:06 UTC

[GitHub] [kafka] aakashnshah commented on pull request #8829: KAFKA-10115: Incorporate errors.tolerance with the Errant Record Reporter

aakashnshah commented on pull request #8829:
URL: https://github.com/apache/kafka/pull/8829#issuecomment-642299655


   I've added a condition to `WorkerSinkTask` in `deliverMessages()` to throw a `ConnectException` if the Errant Record Reporter to account for the case that the developer swallows the exception thrown from `executeFailed(...)` within `put(...)`. Right now, I am storing this information within `WorkerErrantRecordReporter`, let me know if you guys think this is a good idea of it would be better done within `RetryWithToleranceOperator`.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org