You are viewing a plain text version of this content. The canonical link for it is here.

Posted to commits@cassandra.apache.org by "Jason Brown (JIRA)" <ji...@apache.org> on 2013/06/21 00:57:19 UTC

[jira] [Updated] (CASSANDRA-5681) Refactor IESCS in Snitches

     [ https://issues.apache.org/jira/browse/CASSANDRA-5681?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Jason Brown updated CASSANDRA-5681:
-----------------------------------

    Attachment: 5681-v1.diff

Attached v1 patch extracts the IESCS work in Ec2MRS and GPFS into a new helper class, ReconnectableSnitchHelper (which implements IESCS). I choose to create a new 'sidekick/helper' class rather than create a new parent class as Ec2MRS already derives from Ec2Snitch, and it wouldn't make sense to have Ec2Snitch derive from the new 'reconnecting' snitch as it doesn't need the reconnect functionality.

Note: when applying to trunk, will also refactor YamlFileNTS (as it didn't exist in 1.2).
                
> Refactor IESCS in Snitches
> --------------------------
>
>                 Key: CASSANDRA-5681
>                 URL: https://issues.apache.org/jira/browse/CASSANDRA-5681
>             Project: Cassandra
>          Issue Type: Improvement
>          Components: Core
>    Affects Versions: 1.2.5
>            Reporter: Jason Brown
>            Assignee: Jason Brown
>            Priority: Minor
>              Labels: snitch
>             Fix For: 1.2.6, 2.0 beta 1
>
>         Attachments: 5681-v1.diff
>
>
> Reduce/refactor duplicated IESCS implementations in Ec2MRS, GPFS, and YPNTS.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira