You are viewing a plain text version of this content. The canonical link for it is here.
Posted to github@arrow.apache.org by "kou (via GitHub)" <gi...@apache.org> on 2025/04/08 05:40:30 UTC

[PR] GH-46052: [C++][Benchmarking] Don't build grouper benchmark without ARROW_COMPUTE=ON [arrow]

kou opened a new pull request, #46053:
URL: https://github.com/apache/arrow/pull/46053

   ### Rationale for this change
   
   We should not build benchmark program that uses compute module features without `ARROW_COMPUTE=ON`.
   
   ### What changes are included in this PR?
   
   Don't build `grouper_benchmark.cc` without `ARROW_COMPUTE=ON`.
   
   ### Are these changes tested?
   
   Yes.
   
   ### Are there any user-facing changes?
   
   Yes.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] GH-46052: [C++][Benchmarking] Don't build grouper benchmark without ARROW_COMPUTE=ON [arrow]

Posted by "conbench-apache-arrow[bot] (via GitHub)" <gi...@apache.org>.
conbench-apache-arrow[bot] commented on PR #46053:
URL: https://github.com/apache/arrow/pull/46053#issuecomment-2786723331

   After merging your PR, Conbench analyzed the 4 benchmarking runs that have been run so far on merge-commit 8febeadf225b1019d561f91191200faa16afd072.
   
   There were no benchmark performance regressions. 🎉
   
   The [full Conbench report](https://github.com/apache/arrow/runs/40185551989) has more details. It also includes information about 8 possible false positives for unstable benchmarks that are known to sometimes produce them.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] GH-46052: [C++][Benchmarking] Don't build grouper benchmark without ARROW_COMPUTE=ON [arrow]

Posted by "raulcd (via GitHub)" <gi...@apache.org>.
raulcd merged PR #46053:
URL: https://github.com/apache/arrow/pull/46053


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] GH-46052: [C++][Benchmarking] Don't build grouper benchmark without ARROW_COMPUTE=ON [arrow]

Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #46053:
URL: https://github.com/apache/arrow/pull/46053#issuecomment-2785282337

   :warning: GitHub issue #46052 **has been automatically assigned in GitHub** to PR creator.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org